Date: Mon, 16 Apr 2012 20:01:30 +0000 From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> To: Juli Mallett <jmallett@FreeBSD.org> Cc: Andrew Turner <andrew@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r234337 - in head: lib/libc/arm/gen sys/arm/include Message-ID: <AEC8B145-8DD5-4504-8DAF-255B64B6C3D2@lists.zabbadoz.net> In-Reply-To: <CACVs6=8BYYN0ZW7zzHZduns-ZH9hUF=M1EmXfoOkCZVMh1ubpg@mail.gmail.com> References: <201204160938.q3G9cLmw026093@svn.freebsd.org> <CACVs6=8BYYN0ZW7zzHZduns-ZH9hUF=M1EmXfoOkCZVMh1ubpg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 16. Apr 2012, at 19:41 , Juli Mallett wrote: > On Mon, Apr 16, 2012 at 02:38, Andrew Turner <andrew@freebsd.org> wrote: >> Log: >> Replace the C implementation of __aeabi_read_tp with an assembly version. >> This ensures we follow the ABI by preserving registers r1-r3. > >> +ENTRY(__aeabi_read_tp) >> + ldr r0, .Larm_tp_address >> + ldr r0, [r0] >> + RET >> + >> +.Larm_tp_address: >> + .word ARM_TP_ADDRESS >> + > > Why is this indirection required? Can't you just use ARM_TP_ADDRESS > instead of loading it from data? Also, is our convention for ARM to > use END() with ENTRY() or not? Don't you generally want END() . ? -- Bjoern A. Zeeb You have to have visions! It does not matter how good you are. It matters what good you do!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AEC8B145-8DD5-4504-8DAF-255B64B6C3D2>