Date: Sat, 30 Aug 2025 01:32:31 GMT From: Navdeep Parhar <np@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 99f3c684523a - main - cxgbe(4): Fix inverted test in sysctl_loadavg Message-ID: <202508300132.57U1WVmX066630@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=99f3c684523a83280f40c1d29d8a817dd02314b0 commit 99f3c684523a83280f40c1d29d8a817dd02314b0 Author: Navdeep Parhar <np@FreeBSD.org> AuthorDate: 2025-08-30 00:08:39 +0000 Commit: Navdeep Parhar <np@FreeBSD.org> CommitDate: 2025-08-30 01:26:20 +0000 cxgbe(4): Fix inverted test in sysctl_loadavg Only internal debug firmwares report the μP load averages so this bug did not affect regular users. Fixes: e19d84979a18 cxgbe(4): Block most access to the hardware as soon as the adapter stops. MFC after: 1 week Sponsored by: Chelsio Communications --- sys/dev/cxgbe/t4_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/cxgbe/t4_main.c b/sys/dev/cxgbe/t4_main.c index 9e91250cb61c..9756a6945384 100644 --- a/sys/dev/cxgbe/t4_main.c +++ b/sys/dev/cxgbe/t4_main.c @@ -9016,7 +9016,7 @@ sysctl_loadavg(SYSCTL_HANDLER_ARGS) rc = begin_synchronized_op(sc, NULL, SLEEP_OK | INTR_OK, "t4lavg"); if (rc) return (rc); - if (hw_all_ok(sc)) + if (!hw_all_ok(sc)) rc = ENXIO; else { param = V_FW_PARAMS_MNEM(FW_PARAMS_MNEM_DEV) |
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202508300132.57U1WVmX066630>