Date: Sun, 23 Jul 2023 08:15:45 +0100 From: Doug Rabson <dfr@rabson.org> To: Daniel Engberg <diizzy@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: da411ab69810 - main - sysutils/catatonit: new port Message-ID: <CACA0VUioUnqFOYKsbSWSFirf3w_OF7hS7r0Du10p8xkGM0X0Ng@mail.gmail.com> In-Reply-To: <efb9fa02ad54c4a7878091f146d4c925@pyret.net> References: <202307221238.36MCc06w097209@gitrepo.freebsd.org> <efb9fa02ad54c4a7878091f146d4c925@pyret.net>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Sat, 22 Jul 2023 at 15:21, Daniel Engberg <diizzy@freebsd.org> wrote: > > Why is pre-configure section needed if you use USES= autoreconf ? > LICENSE seems to be incorrect? > > https://github.com/dfr/catatonit/commit/96760cc0acb3643a266505b71d025b484e2c4a98 > (see commit message and README.md) > Please define LICENSE_FILE > HAS_CONFIGURE should be GNU_CONFIGURE > Is gmake really needed? Works fine on 13.2-RELEASE using (b)make > If you only have two files in pkg-plist you can also define plist in the > Makefile instead. (optional) > Thanks for the feedback. I don't think I even tried to build with bmake - I guess I assumed that autoconf tends to imply gmake. I'll send you a patch to fix the license issue and other nits. Doug. [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, 22 Jul 2023 at 15:21, Daniel Engberg <<a href="mailto:diizzy@freebsd.org">diizzy@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><br> Why is pre-configure section needed if you use USES= autoreconf ?<br> LICENSE seems to be incorrect? <br> <a href="https://github.com/dfr/catatonit/commit/96760cc0acb3643a266505b71d025b484e2c4a98" rel="noreferrer" target="_blank">https://github.com/dfr/catatonit/commit/96760cc0acb3643a266505b71d025b484e2c4a98</a>; <br> (see commit message and README.md)<br> Please define LICENSE_FILE<br> HAS_CONFIGURE should be GNU_CONFIGURE<br> Is gmake really needed? Works fine on 13.2-RELEASE using (b)make<br> If you only have two files in pkg-plist you can also define plist in the <br> Makefile instead. (optional)<br></blockquote><div><br></div><div>Thanks for the feedback. I don't think I even tried to build with bmake - I guess I assumed that autoconf tends to imply gmake. I'll send you a patch to fix the license issue and other nits.</div><div><br></div><div> Doug.</div></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACA0VUioUnqFOYKsbSWSFirf3w_OF7hS7r0Du10p8xkGM0X0Ng>