Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 20 Jan 2006 22:32:32 +1100
From:      Edwin Groothuis <edwin@mavetju.org>
To:        Sergey Skvortsov <skv@FreeBSD.org>
Cc:        cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/net/ssldump/files patch-ssl%ssldecode.c
Message-ID:  <20060120113232.GD1026@k7.mavetju>
In-Reply-To: <43D0C93D.1050704@FreeBSD.org>
References:  <200601201014.k0KAEMQ5053386@repoman.freebsd.org> <20060120102934.GB1026@k7.mavetju> <43D0BE68.6010403@FreeBSD.org> <20060120105326.GC1026@k7.mavetju> <43D0C93D.1050704@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jan 20, 2006 at 02:27:57PM +0300, Sergey Skvortsov wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Edwin Groothuis wrote:
> >>
> >> Edwin Groothuis wrote:
> >>>>   FreeBSD ports repository
> >>>>
> >>>>   Added files:
> >>>>     net/ssldump/files    patch-ssl%ssldecode.c 
> >>> Did I miss a naming-convention change?
> >
> >> History repeats itself... Ok.
> >>
> >> 1. I dislike "_" as path delimiter. It's not so obvious and aesthetic as
> >> "::" or "%".
> > 
> > I don't like it neither, but I accepted the fact that there was a
> > proper naming standard for it so at least this wildgrowth of patch
> > files would be resolved.
> 
> First of all, it is not a "proper naming standard". I always suggest to
> use SHOULD/MUST/etc words (RFC 2119) in "Porters' Handboook" to avoid
> any incomprehension. In current situation I prefer to treat "Please only
> use characters [-+._a-zA-Z0-9]" as "You SHOULD use characters
> [-+._a-zA-Z0-9]".
> 
> Many committers do not like this "convention". Hence the above regex
> should be reviewed and extended. There is no technical problems with
> additional ":%" symbols. Patch names must be convenient, not procrustean.

Please stop being so annoying, and follow the spirit of the guide
instead of the letter of the guide.

I'm now off to bed, I'll see what I have to do in the morning.

Edwin

-- 
Edwin Groothuis      |            Personal website: http://www.mavetju.org
edwin@mavetju.org    |          Weblog: http://weblog.barnet.com.au/edwin/



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060120113232.GD1026>