Date: Mon, 06 Apr 2015 21:11:21 +0000 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: John Baldwin <jhb@freebsd.org> Cc: Eric Badger <eric@badgerio.us>, freebsd-current@freebsd.org Subject: Re: Early use of log() does not end up in kernel msg buffer Message-ID: <70135.1428354681@critter.freebsd.dk> In-Reply-To: <2033248.Eu3RHS8lTG@ralph.baldwin.cx> References: <5514CC6D.3020607@badgerio.us> <2033248.Eu3RHS8lTG@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
--------
In message <2033248.Eu3RHS8lTG@ralph.baldwin.cx>, John Baldwin writes:
>I think phk@ broke this back in 70239. Before that the log() function did
>this:
>
>log()
>{
>
> /* log to the msg buffer */
> kvprintf(fmt, msglogchar, ...);
>
> if (!log_open) {
> /* log to console */
> kvprintf(fmt, putchar, ...);
> }
>}
>
>I think your patch is fine unless phk@ (cc'd) has a reason for not wanting to
>do this.
The reason was systems not running syslog having slow serial consoles.
--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?70135.1428354681>