Date: Wed, 19 Oct 2011 17:47:23 -0400 From: Ryan Stone <rysto32@gmail.com> To: Juli Mallett <jmallett@freebsd.org> Cc: freebsd-net <freebsd-net@freebsd.org>, Rozhuk.IM@gmail.com Subject: Re: ether_demux does not handle frames with embedded vlan tags Message-ID: <CAFMmRNxeiQF=iBDAQT4fQjvmmTA6=ygsEJQfAJW=Go1tSTtQSg@mail.gmail.com> In-Reply-To: <CACVs6=_6gHDay96a=pSw6Un_6fh=fuAew=DWYvWokBnyA=Y7Lg@mail.gmail.com> References: <CAFMmRNz2Gqmk7wmiA83eQZfR9Rkcro9seD5ORYRHxKhZV%2BaR9Q@mail.gmail.com> <4e9e0de3.4364cc0a.38b5.ffffc94f@mx.google.com> <CAFMmRNxMPh9SOwXHR8uWqNMR=ns5HfFzb2OiB=wC2Kn%2B61PKbQ@mail.gmail.com> <4e9e6ba6.c972cd0a.3d45.ffffd504@mx.google.com> <CAFMmRNxoJafz9kz66sQXVYcsvd-tr8wqkh_-BbfhHD8RqRygKA@mail.gmail.com> <CACVs6=_6gHDay96a=pSw6Un_6fh=fuAew=DWYvWokBnyA=Y7Lg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 19, 2011 at 3:30 PM, Juli Mallett <jmallett@freebsd.org> wrote: > Why should the requirements for the Netgraph path be any different to > the non-Netgraph path? =A0If drivers must ensure that frames that reach > ether_demux have had their VLAN tags stripped, so should Netgraph > things that act like drivers. =A0So why don't you move that logic into > ether_demux from the ether_input path, or have Netgraph use the > ether_input path? Netgraph can't use the ether_input path because ether_input passes the packet to the lower hook. It also passes the packet to things like carp or if_bridge if necessary. I'm not sure whether it is intended behaviour that the upper hook bypasses carp and if_bridge. if_bridge also depends on the vlan stripping behaviour, so vlan stripping cannot be moved to ether_demux without re-implementing it in bridge_input.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFMmRNxeiQF=iBDAQT4fQjvmmTA6=ygsEJQfAJW=Go1tSTtQSg>