Date: Thu, 1 Aug 2019 15:31:15 -0400 From: Mark Johnston <markj@freebsd.org> To: Steve Kargl <sgk@troutmask.apl.washington.edu> Cc: freebsd-x11@freebsd.org, freebsd-current@freebsd.org Subject: Re: drm-legacy is broken, again Message-ID: <20190801193115.GC19051@raichu> In-Reply-To: <20190801193024.GA29819@troutmask.apl.washington.edu> References: <20190801191009.GA8229@troutmask.apl.washington.edu> <20190801192227.GB19051@raichu> <20190801193024.GA29819@troutmask.apl.washington.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Aug 01, 2019 at 12:30:24PM -0700, Steve Kargl wrote:
> On Thu, Aug 01, 2019 at 03:22:27PM -0400, Mark Johnston wrote:
> > On Thu, Aug 01, 2019 at 12:10:09PM -0700, Steve Kargl wrote:
> > > Just updated /usr/src to top of tree.
> > >
> > > Trying to update drm-legacy port. After
> > > a failed 'make' in /usr/ports/drm-legacy
> >
> > The patch below should fix it. drm was relying on refcount.h including
> > limits.h.
> >
> > diff --git a/src/dev/drm2/drmP.h b/src/dev/drm2/drmP.h
> > index 3af7ad1..7cbd8db 100644
> > --- a/src/dev/drm2/drmP.h
> > +++ b/src/dev/drm2/drmP.h
> > @@ -42,6 +42,7 @@ __FBSDID("$FreeBSD$");
> >
> > #include <sys/param.h>
> > #include <sys/queue.h>
> > +#include <sys/limits.h>
> > #include <sys/malloc.h>
> > #include <sys/kernel.h>
> > #include <sys/ktr.h>
>
> Thanks for the quick response. I had recalled someone
> has/had been undoing some header pollution changes,
> but the individual names escaped me.
I reproduced the issue and submitted a PR:
https://github.com/FreeBSDDesktop/drm-legacy/pull/13
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190801193115.GC19051>