Date: Mon, 31 Aug 2015 01:50:44 -0700 From: Adrian Chadd <adrian@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r287312 - head/sys/dev/iwn Message-ID: <CAJ-Vmom5DuL9%2B6%2BEosii%2B_uuSxLJFoTGxJEnRBhGOS4=Bm6pbw@mail.gmail.com> In-Reply-To: <20150831084333.GP2072@kib.kiev.ua> References: <201508302154.t7ULsXaT070453@repo.freebsd.org> <20150831084333.GP2072@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 31 August 2015 at 01:43, Konstantin Belousov <kostikbel@gmail.com> wrote:
> On Sun, Aug 30, 2015 at 09:54:33PM +0000, Adrian Chadd wrote:
>> static int
>> -iwn_ioctl(struct ieee80211com *ic, u_long cmd, void *data)
>> +iwn_cdev_open(struct cdev *dev, int flags, int type, struct thread *td)
>> {
>> - struct ifreq *ifr = data;
>> - struct iwn_softc *sc = ic->ic_softc;
>> - int error = 0;
>> -
>> +
>> + return (0);
>> +}
>> +
>> +static int
>> +iwn_cdev_close(struct cdev *dev, int flags, int type, struct thread *td)
>> +{
>> +
>> + return (0);
>> +}
>
> devfs does the right thing for drivers which does not provide d_open and
> d_close methods, these empty stubs are not needed.
I'll remove them tomorrow. I copied off of cxgbe, which does this.
Thanks!
-adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmom5DuL9%2B6%2BEosii%2B_uuSxLJFoTGxJEnRBhGOS4=Bm6pbw>