Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 31 Dec 2021 19:02:08 -0400
From:      Eric Turgeon <ericturgeon.bsd@gmail.com>
To:        Tomoaki AOKI <junchoon@dec.sakura.ne.jp>
Cc:        Cy Schubert <Cy.Schubert@cschubert.com>, dev-commits-ports-main@freebsd.org,  Cy Schubert <cy@freebsd.org>
Subject:   Re: git: f3caf742108b - main - x11/mate-screensaver: Fix PAM build
Message-ID:  <CADRZFmpTOMeR4%2Bk2Z7nr3j_d6-%2BUMP-tZ-7V48FszQwiKNEQ3g@mail.gmail.com>
In-Reply-To: <CADRZFmotJHhOmjH1pfv3S-4Bp_77EPMWKGVpXhGaxzODy37hmA@mail.gmail.com>
References:  <20211230110857.1c0ac0e19e8206cb64a040d7@dec.sakura.ne.jp> <202112300342.1BU3gPt9003879@slippy.cwsent.com> <CADRZFmrE8avprf7NZPcU%2BtbsgVBzk9=qp4zHKgxLXSOK60QQQw@mail.gmail.com> <202112301701.1BUH1dji009235@slippy.cwsent.com> <202112310402.1BV42p3C036429@slippy.cwsent.com> <CADRZFmqsPFD8GS1H8W4pKC%2BoRUu4yJ%2BZ9WMBaSo7GsOH8K7XOQ@mail.gmail.com> <20211231162719.3f7f909008d3cbacefe124c0@dec.sakura.ne.jp> <CADRZFmotJHhOmjH1pfv3S-4Bp_77EPMWKGVpXhGaxzODy37hmA@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000bcd0f505d4792923
Content-Type: text/plain; charset="UTF-8"

I made a GitHub issue
https://github.com/mate-desktop/mate-screensaver/issues/272 with the
information I have so far.

*Eric Turgeon*


On Fri, Dec 31, 2021 at 6:05 PM Eric Turgeon <ericturgeon.bsd@gmail.com>
wrote:

> Ok, I made a fork of mate-desktop/mate-screensaver
> <https://github.com/mate-desktop/mate-screensaver>; and reverted
> https://github.com/mate-desktop/mate-screensaver/commit/ec813dffa59d30fa30ab3e4932095337b5813132#diff-aeac78bee2093aadfdb2899062cd27c459b83549bbb843417bf3693ca58673a2
> and
> https://github.com/mate-desktop/mate-screensaver/commit/ec813dffa59d30fa30ab3e4932095337b5813132#diff-3ff2c5a579bd5353be616133d0eef15a260c9f44f9064a5a36b58cb7c4b1d989
> .
> I did run sh autogen.sh --with-console-kit=yes --with-systemd=no
> --enable-authentication-scheme=helper
> --with-passwd-helper=/usr/local/bin/pam_helper, gmake and sudo gmake
> install.
> Everything is back to normal now I am trying to find if
> src/gs-auth-helper.c or src/gs-auth-helper.c is the problem.
> *Eric Turgeon*
>
>
> On Fri, Dec 31, 2021 at 3:27 AM Tomoaki AOKI <junchoon@dec.sakura.ne.jp>
> wrote:
>
>> That's what I pointed as suspicious (but couldn't track where the
>> problem lives in) on Bug 260811.
>>
>> If introducing missing header(s) is suffice, and any open source
>> software having it allows partial use, creating header-only port
>> deriving from it can be an option.
>>
>> For example, electron* ports are derived from chromium.
>>
>>
>> On Fri, 31 Dec 2021 00:27:34 -0400
>> Eric Turgeon <ericturgeon.bsd@gmail.com> wrote:
>>
>> > It is most likely this commit
>> >
>> https://github.com/mate-desktop/mate-screensaver/commit/ed6e6065bf0e85b64317b5a34b9f7a36a0c839a6
>> > .
>> >
>> > *Eric Turgeon*
>> >
>> >
>> > On Fri, Dec 31, 2021 at 12:02 AM Cy Schubert <Cy.Schubert@cschubert.com
>> >
>> > wrote:
>> >
>> > > I can confirm PAM authentication is broken by this new release. Like
>> > > layers
>> > > of an onion, this problem will need to be investigated further. I
>> doubt
>> > > simply adding additional macros would resolve the problem. The reason
>> I
>> > > believe this is that the macros are likely a small part of something
>> > > larger.
>> > >
>> > > Having said that, ports/security/pecl-pam includes a copy of the file
>> with
>> > > a reference to the URL from whence it came (suggesting a GPL
>> violation in
>> > > the ports tree).
>> > >
>> > > I think the path forward is to engage our upstream. Then look at a
>> number
>> > > of short-term or longer-term options to get us over this hump.
>> > >
>> > > If upstream is open to fixing the problem temporarily marking the PAM
>> > > option broken or temporarily rolling back the upgrade may suffice.
>> > >
>> > > Alternatively, if upstream isn't open to remediation we may want to
>> > > consider importing Linux-pam on github as a port. Be aware that
>> multiple
>> > > PAM stacks can coexist however similar problems we have with three
>> KRB5s
>> > > will require getting linking just right. This option does have the
>> > > advantage of supporting other software written for Linux-PAM (instead
>> of
>> > > OpenPAM or Solaris PAM -- FreeBSD PAM is based on OpenPAM).
>> > >
>> > > Another alternative is dump mate-screensaver for xscreensaver. IIRC
>> > > xscreensaver was the original screen saver for Gnome back in the day.
>> (IMO
>> > > xscreensaver is superior to the Gnome and mate screensavers, though
>> this
>> > > is
>> > > just a personal preference. I've also used it to replace the CDE
>> > > screensaver on a per-user basis.) Anyhow, just a thought for anyone.
>> > >
>> > > Until we look at the code we won't have a good idea of what kind of
>> work
>> > > is
>> > > involved.
>> > >
>> > > Strategically a Linux-PAM port might be something we might want to
>> think
>> > > about long term. Tactically, any of the other options could work.
>> > >
>> > >
>> > > --
>> > > Cheers,
>> > > Cy Schubert <Cy.Schubert@cschubert.com>
>> > > FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  https://FreeBSD.org
>> > > NTP:           <cy@nwtime.org>    Web:  https://nwtime.org
>> > >
>> > >         The need of the many outweighs the greed of the few.
>> > >
>> > >
>> > > In message <202112301701.1BUH1dji009235@slippy.cwsent.com>, Cy
>> Schubert
>> > > writes:
>> > > > No. It's a bunch of inline macros that perform memory and other
>> > > functions.
>> > > > All could have been made to be actual functions. On my Fedora VM at
>> $JOB
>> > > > they're part of the pam-devel.rpm.
>> > > >
>> > > >
>> > > > --
>> > > > Cheers,
>> > > > Cy Schubert <Cy.Schubert@cschubert.com>
>> > > > FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  https://FreeBSD.org
>> > > > NTP:           <cy@nwtime.org>    Web:  https://nwtime.org
>> > > >
>> > > >       The need of the many outweighs the greed of the few.
>> > > >
>> > > >
>> > > > In message
>> > > <CADRZFmrE8avprf7NZPcU+tbsgVBzk9=qp4zHKgxLXSOK60QQQw@mail.gmail.c
>> > > > om>
>> > > > , Eric Turgeon writes:
>> > > > > --00000000000063b43405d45dfc6d
>> > > > > Content-Type: text/plain; charset="UTF-8"
>> > > > >
>> > > > > Do we have an equivalent of security/_pam_macros.h?
>> > > > >
>> > > > > *Eric Turgeon*
>> > > > >
>> > > > >
>> > > > > On Wed, Dec 29, 2021 at 11:42 PM Cy Schubert <
>> > > Cy.Schubert@cschubert.com>
>> > > > > wrote:
>> > > > >
>> > > > > > This commit only fixed a compile time error, include file
>> > > > > > security/_pam_macros.h not found (discovered by my poudriere
>> build).
>> > > > > > security/_pam_macros is an include file found only on some
>> distros of
>> > > > > > Linux, a Linuxism. Try it without PAM enabled; the file not
>> found
>> > > error
>> > > > > > may
>> > > > > > just be the beginning of a multitude of PAM issues.
>> > > > > >
>> > > > > > I'll try to look at it over the next couple days.
>> > > > > >
>> > > > > >
>> > > > > > --
>> > > > > > Cheers,
>> > > > > > Cy Schubert <Cy.Schubert@cschubert.com>
>> > > > > > FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  https://FreeBSD.org
>> > > > > > NTP:           <cy@nwtime.org>    Web:  https://nwtime.org
>> > > > > >
>> > > > > >         The need of the many outweighs the greed of the few.
>> > > > > >
>> > > > > >
>> > > > > > In message <
>> 20211230110857.1c0ac0e19e8206cb64a040d7@dec.sakura.ne.jp
>> > > >,
>> > > > > > Tomoaki
>> > > > > > AOKI writes:
>> > > > > > > Hi.
>> > > > > > > Wondered whih commit to comment but decided to latest.
>> > > > > > > mate-screensaver no longer opens login panel after upgrading
>> from
>> > > > > > > 1.26.0 to 1.26.1.
>> > > > > > >
>> > > > > > > Created Bug 260811 [1].
>> > > > > > >
>> > > > > > > [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=260811
>> > > > > > >
>> > > > > > >
>> > > > > > > > The branch main has been updated by cy:
>> > > > > > > >
>> > > > > > > > URL:
>> > > > > > >
>> > > > > >
>> > >
>> https://cgit.FreeBSD.org/ports/commit/?id=f3caf742108bb552724d4c4dae74b28
>> > > > ea
>> > > > > 26
>> > > > > > > 6a6a3
>> > > > > > > >
>> > > > > > > > commit f3caf742108bb552724d4c4dae74b28ea266a6a3
>> > > > > > > > Author:     Cy Schubert <cy_at_FreeBSD.org>
>> > > > > > > > AuthorDate: 2021-12-29 03:12:39 +0000
>> > > > > > > > Commit:     Cy Schubert <cy_at_FreeBSD.org>
>> > > > > > > > CommitDate: 2021-12-29 03:12:39 +0000
>> > > > > > > >
>> > > > > > > >     x11/mate-screensaver: Fix PAM build
>> > > > > > > >
>> > > > > > > >     Fix build when PAM enabled; <security/_pam_macros.h> is
>> a
>> > > Linuxis
>> > > > m.
>> > > > > > > > ---
>> > > > > > > >  x11/mate-screensaver/files/patch-helper_pam-helper.c | 10
>> > > ++++++++++
>> > > > > > > >  1 file changed, 10 insertions(+)
>> > > > > > > >
>> > > > > > > > diff --git
>> a/x11/mate-screensaver/files/patch-helper_pam-helper.c
>> > > > > > > b/x11/mate-screensaver/files/patch-helper_pam-helper.c
>> > > > > > > > new file mode 100644
>> > > > > > > > index 000000000000..605141fb0e54
>> > > > > > > > --- /dev/null
>> > > > > > > > +++ b/x11/mate-screensaver/files/patch-helper_pam-helper.c
>> > > > > > > > _at__at_ -0,0 +1,10 _at__at_
>> > > > > > > > +--- helper/pam-helper.c.orig       2021-11-15
>> > > 14:28:47.000000000 -08
>> > > > 00
>> > > > > > > > ++++ helper/pam-helper.c    2021-12-28 19:09:39.501645000
>> -0800
>> > > > > > > > +_at__at_ -33,7 +33,6 _at__at_
>> > > > > > > > +  */
>> > > > > > > > +
>> > > > > > > > + #include <security/pam_appl.h>
>> > > > > > > > +-#include <security/_pam_macros.h>
>> > > > > > > > +
>> > > > > > > > + #include <sys/types.h>
>> > > > > > > > + #include <stdarg.h>
>> > > > > > >
>> > > > > > > --
>> > > > > > > Tomoaki AOKI    <junchoon@dec.sakura.ne.jp>
>> > > > > >
>> > > > > >
>> > > > > >
>> > > > >
>> > > > > --00000000000063b43405d45dfc6d
>> > > > > Content-Type: text/html; charset="UTF-8"
>> > > > > Content-Transfer-Encoding: quoted-printable
>> > > > >
>> > > > > <div dir=3D"ltr"><div>Do we have an equivalent of
>> > > security/_pam_macros.h?</
>> > > > =
>> > > > > div><div><br></div><div><div><div dir=3D"ltr"
>> > > class=3D"gmail_signature" dat
>> > > > =
>> > > > > a-smartmail=3D"gmail_signature"><div dir=3D"ltr"><div><div
>> > > dir=3D"ltr"><div
>> > > > =
>> > > > > ><div dir=3D"ltr"><div><div dir=3D"ltr"><div
>> dir=3D"ltr"><span><font
>> > > color=
>> > > > > =3D"#888888"><font><font color=3D"#000000"><b>Eric
>> > > Turgeon</b></font></font
>> > > > =
>> > > > >
>> > >
>> ></font></span><span></span><cite></cite><br></div><span></span></div></div
>> > > > =
>> > > > >
>> ></div></div></div></div></div></div></div><br></div></div><br><div
>> > > class=
>> > > > > =3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Wed,
>> Dec 29,
>> > > 2021
>> > > > =
>> > > > >  at 11:42 PM Cy Schubert &lt;<a href=3D"mailto:
>> > > Cy.Schubert@cschubert.com">C
>> > > > =
>> > > > > y.Schubert@cschubert.com</a>&gt; wrote:<br></div><blockquote
>> > > class=3D"gmail
>> > > > =
>> > > > > _quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid
>> > > rgb(204,204
>> > > > =
>> > > > > ,204);padding-left:1ex">This commit only fixed a compile time
>> error,
>> > > includ
>> > > > =
>> > > > > e file <br>
>> > > > > security/_pam_macros.h not found (discovered by my poudriere
>> build).
>> > > <br>
>> > > > > security/_pam_macros is an include file found only on some
>> distros of
>> > > <br>
>> > > > > Linux, a Linuxism. Try it without PAM enabled; the file not found
>> > > error may
>> > > > =
>> > > > >  <br>
>> > > > > just be the beginning of a multitude of PAM issues.<br>
>> > > > > <br>
>> > > > > I&#39;ll try to look at it over the next couple days.<br>
>> > > > > <br>
>> > > > > <br>
>> > > > > -- <br>
>> > > > > Cheers,<br>
>> > > > > Cy Schubert &lt;<a href=3D"mailto:Cy.Schubert@cschubert.com"
>> > > target=3D"_bla
>> > > > =
>> > > > > nk">Cy.Schubert@cschubert.com</a>&gt;<br>
>> > > > > FreeBSD UNIX:=C2=A0 &lt;cy@FreeBSD.org&gt;=C2=A0
>> =C2=A0Web:=C2=A0 <a
>> > > href=
>> > > > > =3D"https://FreeBSD.org" rel=3D"noreferrer" target=3D"_blank">
>> > > https://FreeB
>> > > > =
>> > > > > SD.org</a><br>
>> > > > > NTP:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&lt;<a
>> href=3D"mailto:
>> > > cy@nwtim
>> > > > =
>> > > > > e.org" target=3D"_blank">cy@nwtime.org</a>&gt;=C2=A0 =C2=A0
>> > > Web:=C2=A0 <a h
>> > > > =
>> > > > > ref=3D"https://nwtime.org" rel=3D"noreferrer" target=3D"_blank">
>> > > https://nwt
>> > > > =
>> > > > > ime.org</a><br>
>> > > > > <br>
>> > > > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 The need of the many outweighs the
>> greed
>> > > of the
>> > > > =
>> > > > >  few.<br>
>> > > > > <br>
>> > > > > <br>
>> > > > > In message &lt;<a href=3D"mailto:
>> > > 20211230110857.1c0ac0e19e8206cb64a040d7@de
>> > > > =
>> > > > > c.sakura.ne.jp"
>> > > target=3D"_blank">20211230110857.1c0ac0e19e8206cb64a040d7@d
>> > > > =
>> > > > > ec.sakura.ne.jp</a>&gt;, <br>
>> > > > > Tomoaki<br>
>> > > > > AOKI writes:<br>
>> > > > > &gt; Hi.<br>
>> > > > > &gt; Wondered whih commit to comment but decided to latest.<br>
>> > > > > &gt; mate-screensaver no longer opens login panel after upgrading
>> > > from<br>
>> > > > > &gt; 1.26.0 to 1.26.1.<br>
>> > > > > &gt;<br>
>> > > > > &gt; Created Bug 260811 [1].<br>
>> > > > > &gt;<br>
>> > > > > &gt; [1] <a href=3D"
>> > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D260
>> > > > =
>> > > > > 811" rel=3D"noreferrer" target=3D"_blank">
>> > > https://bugs.freebsd.org/bugzilla
>> > > > =
>> > > > > /show_bug.cgi?id=3D260811</a><br>
>> > > > > &gt;<br>
>> > > > > &gt;<br>
>> > > > > &gt; &gt; The branch main has been updated by cy:<br>
>> > > > > &gt; &gt; <br>
>> > > > > &gt; &gt; URL:<br>
>> > > > > &gt; <a href=3D"
>> > > https://cgit.FreeBSD.org/ports/commit/?id=3Df3caf742108bb55
>> > > > =
>> > > > > 2724d4c4dae74b28ea26" rel=3D"noreferrer" target=3D"_blank">
>> > > https://cgit.Fre
>> > > > =
>> > > > >
>> eBSD.org/ports/commit/?id=3Df3caf742108bb552724d4c4dae74b28ea26</a><br>
>> > > > > &gt; 6a6a3<br>
>> > > > > &gt; &gt; <br>
>> > > > > &gt; &gt; commit f3caf742108bb552724d4c4dae74b28ea266a6a3<br>
>> > > > > &gt; &gt; Author:=C2=A0 =C2=A0 =C2=A0Cy Schubert
>> > > &lt;cy_at_FreeBSD.org&gt;<
>> > > > =
>> > > > > br>
>> > > > > &gt; &gt; AuthorDate: 2021-12-29 03:12:39 +0000<br>
>> > > > > &gt; &gt; Commit:=C2=A0 =C2=A0 =C2=A0Cy Schubert
>> > > &lt;cy_at_FreeBSD.org&gt;<
>> > > > =
>> > > > > br>
>> > > > > &gt; &gt; CommitDate: 2021-12-29 03:12:39 +0000<br>
>> > > > > &gt; &gt; <br>
>> > > > > &gt; &gt;=C2=A0 =C2=A0 =C2=A0x11/mate-screensaver: Fix PAM
>> build<br>
>> > > > > &gt; &gt;=C2=A0 =C2=A0 =C2=A0<br>
>> > > > > &gt; &gt;=C2=A0 =C2=A0 =C2=A0Fix build when PAM enabled;
>> > > &lt;security/_pam_
>> > > > =
>> > > > > macros.h&gt; is a Linuxism.<br>
>> > > > > &gt; &gt; ---<br>
>> > > > > &gt; &gt;=C2=A0
>> x11/mate-screensaver/files/patch-helper_pam-helper.c |
>> > > 10 +
>> > > > =
>> > > > > +++++++++<br>
>> > > > > &gt; &gt;=C2=A0 1 file changed, 10 insertions(+)<br>
>> > > > > &gt; &gt; <br>
>> > > > > &gt; &gt; diff --git
>> > > a/x11/mate-screensaver/files/patch-helper_pam-helper.c
>> > > > =
>> > > > > <br>
>> > > > > &gt; b/x11/mate-screensaver/files/patch-helper_pam-helper.c<br>
>> > > > > &gt; &gt; new file mode 100644<br>
>> > > > > &gt; &gt; index 000000000000..605141fb0e54<br>
>> > > > > &gt; &gt; --- /dev/null<br>
>> > > > > &gt; &gt; +++
>> > > b/x11/mate-screensaver/files/patch-helper_pam-helper.c<br>
>> > > > > &gt; &gt; _at__at_ -0,0 +1,10 _at__at_<br>
>> > > > > &gt; &gt; +--- helper/pam-helper.c.orig=C2=A0 =C2=A0 =C2=A0
>> > > =C2=A02021-11-1
>> > > > =
>> > > > > 5 14:28:47.000000000 -0800<br>
>> > > > > &gt; &gt; ++++ helper/pam-helper.c=C2=A0 =C2=A0 2021-12-28
>> > > 19:09:39.5016450
>> > > > =
>> > > > > 00 -0800<br>
>> > > > > &gt; &gt; +_at__at_ -33,7 +33,6 _at__at_<br>
>> > > > > &gt; &gt; +=C2=A0 */<br>
>> > > > > &gt; &gt; + <br>
>> > > > > &gt; &gt; + #include &lt;security/pam_appl.h&gt;<br>
>> > > > > &gt; &gt; +-#include &lt;security/_pam_macros.h&gt;<br>
>> > > > > &gt; &gt; + <br>
>> > > > > &gt; &gt; + #include &lt;sys/types.h&gt;<br>
>> > > > > &gt; &gt; + #include &lt;stdarg.h&gt;<br>
>> > > > > &gt;<br>
>> > > > > &gt; -- <br>
>> > > > > &gt; Tomoaki AOKI=C2=A0 =C2=A0 &lt;<a href=3D"mailto:
>> > > junchoon@dec.sakura.ne
>> > > > =
>> > > > > .jp" target=3D"_blank">junchoon@dec.sakura.ne.jp</a>&gt;<br>
>> > > > > <br>
>> > > > > <br>
>> > > > > </blockquote></div>
>> > > > >
>> > > > > --00000000000063b43405d45dfc6d--
>> > > >
>> > >
>> > >
>> > >
>>
>>
>> --
>> Tomoaki AOKI    <junchoon@dec.sakura.ne.jp>
>>
>

--000000000000bcd0f505d4792923
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>I made a GitHub issue=C2=A0 <a href=3D"https://github=
.com/mate-desktop/mate-screensaver/issues/272">https://github.com/mate-desk=
top/mate-screensaver/issues/272</a> with the information I have so far.</di=
v><div><br></div><div><div dir=3D"ltr" class=3D"gmail_signature" data-smart=
mail=3D"gmail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div d=
ir=3D"ltr"><div><div dir=3D"ltr"><div dir=3D"ltr"><span><font color=3D"#888=
888"><font><font color=3D"#000000"><b>Eric Turgeon</b></font></font></font>=
</span><span></span><cite></cite><br></div><span></span></div></div></div><=
/div></div></div></div></div></div><br></div><br><div class=3D"gmail_quote"=
><div dir=3D"ltr" class=3D"gmail_attr">On Fri, Dec 31, 2021 at 6:05 PM Eric=
 Turgeon &lt;<a href=3D"mailto:ericturgeon.bsd@gmail.com">ericturgeon.bsd@g=
mail.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D=
"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-le=
ft:1ex"><div dir=3D"ltr"><div><div>Ok, I made a fork of <span><a href=3D"ht=
tps://github.com/mate-desktop/mate-screensaver" target=3D"_blank">mate-desk=
top/mate-screensaver</a> and reverted=C2=A0 <a href=3D"https://github.com/m=
ate-desktop/mate-screensaver/commit/ec813dffa59d30fa30ab3e4932095337b581313=
2#diff-aeac78bee2093aadfdb2899062cd27c459b83549bbb843417bf3693ca58673a2" ta=
rget=3D"_blank">https://github.com/mate-desktop/mate-screensaver/commit/ec8=
13dffa59d30fa30ab3e4932095337b5813132#diff-aeac78bee2093aadfdb2899062cd27c4=
59b83549bbb843417bf3693ca58673a2</a> and <a href=3D"https://github.com/mate=
-desktop/mate-screensaver/commit/ec813dffa59d30fa30ab3e4932095337b5813132#d=
iff-3ff2c5a579bd5353be616133d0eef15a260c9f44f9064a5a36b58cb7c4b1d989" targe=
t=3D"_blank">https://github.com/mate-desktop/mate-screensaver/commit/ec813d=
ffa59d30fa30ab3e4932095337b5813132#diff-3ff2c5a579bd5353be616133d0eef15a260=
c9f44f9064a5a36b58cb7c4b1d989</a>.<br></span></div><span>I did run sh autog=
en.sh --with-console-kit=3Dyes --with-systemd=3Dno --enable-authentication-=
scheme=3Dhelper --with-passwd-helper=3D/usr/local/bin/pam_helper</span><spa=
n>, gmake and sudo gmake install.</span></div><div>Everything is back to no=
rmal now I am trying to find if src/gs-auth-helper.c or src/gs-auth-helper.=
c is the problem.<br></div><div><span></span></div><div><div><div><div><div=
 dir=3D"ltr"><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr"><=
div><div dir=3D"ltr"><div dir=3D"ltr"><span><font color=3D"#888888"><font><=
font color=3D"#000000"><b>Eric Turgeon</b></font></font></font></span><span=
></span><cite></cite><br></div><span></span></div></div></div></div></div><=
/div></div></div></div><br></div></div></div></div><br><div class=3D"gmail_=
quote"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, Dec 31, 2021 at 3:27 A=
M Tomoaki AOKI &lt;<a href=3D"mailto:junchoon@dec.sakura.ne.jp" target=3D"_=
blank">junchoon@dec.sakura.ne.jp</a>&gt; wrote:<br></div><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg=
b(204,204,204);padding-left:1ex">That&#39;s what I pointed as suspicious (b=
ut couldn&#39;t track where the<br>
problem lives in) on Bug 260811.<br>
<br>
If introducing missing header(s) is suffice, and any open source<br>
software having it allows partial use, creating header-only port<br>
deriving from it can be an option.<br>
<br>
For example, electron* ports are derived from chromium.<br>
<br>
<br>
On Fri, 31 Dec 2021 00:27:34 -0400<br>
Eric Turgeon &lt;<a href=3D"mailto:ericturgeon.bsd@gmail.com" target=3D"_bl=
ank">ericturgeon.bsd@gmail.com</a>&gt; wrote:<br>
<br>
&gt; It is most likely this commit<br>
&gt; <a href=3D"https://github.com/mate-desktop/mate-screensaver/commit/ed6=
e6065bf0e85b64317b5a34b9f7a36a0c839a6" rel=3D"noreferrer" target=3D"_blank"=
>https://github.com/mate-desktop/mate-screensaver/commit/ed6e6065bf0e85b643=
17b5a34b9f7a36a0c839a6</a><br>
&gt; .<br>
&gt; <br>
&gt; *Eric Turgeon*<br>
&gt; <br>
&gt; <br>
&gt; On Fri, Dec 31, 2021 at 12:02 AM Cy Schubert &lt;<a href=3D"mailto:Cy.=
Schubert@cschubert.com" target=3D"_blank">Cy.Schubert@cschubert.com</a>&gt;=
<br>
&gt; wrote:<br>
&gt; <br>
&gt; &gt; I can confirm PAM authentication is broken by this new release. L=
ike<br>
&gt; &gt; layers<br>
&gt; &gt; of an onion, this problem will need to be investigated further. I=
 doubt<br>
&gt; &gt; simply adding additional macros would resolve the problem. The re=
ason I<br>
&gt; &gt; believe this is that the macros are likely a small part of someth=
ing<br>
&gt; &gt; larger.<br>
&gt; &gt;<br>
&gt; &gt; Having said that, ports/security/pecl-pam includes a copy of the =
file with<br>
&gt; &gt; a reference to the URL from whence it came (suggesting a GPL viol=
ation in<br>
&gt; &gt; the ports tree).<br>
&gt; &gt;<br>
&gt; &gt; I think the path forward is to engage our upstream. Then look at =
a number<br>
&gt; &gt; of short-term or longer-term options to get us over this hump.<br=
>
&gt; &gt;<br>
&gt; &gt; If upstream is open to fixing the problem temporarily marking the=
 PAM<br>
&gt; &gt; option broken or temporarily rolling back the upgrade may suffice=
.<br>
&gt; &gt;<br>
&gt; &gt; Alternatively, if upstream isn&#39;t open to remediation we may w=
ant to<br>
&gt; &gt; consider importing Linux-pam on github as a port. Be aware that m=
ultiple<br>
&gt; &gt; PAM stacks can coexist however similar problems we have with thre=
e KRB5s<br>
&gt; &gt; will require getting linking just right. This option does have th=
e<br>
&gt; &gt; advantage of supporting other software written for Linux-PAM (ins=
tead of<br>
&gt; &gt; OpenPAM or Solaris PAM -- FreeBSD PAM is based on OpenPAM).<br>
&gt; &gt;<br>
&gt; &gt; Another alternative is dump mate-screensaver for xscreensaver. II=
RC<br>
&gt; &gt; xscreensaver was the original screen saver for Gnome back in the =
day. (IMO<br>
&gt; &gt; xscreensaver is superior to the Gnome and mate screensavers, thou=
gh this<br>
&gt; &gt; is<br>
&gt; &gt; just a personal preference. I&#39;ve also used it to replace the =
CDE<br>
&gt; &gt; screensaver on a per-user basis.) Anyhow, just a thought for anyo=
ne.<br>
&gt; &gt;<br>
&gt; &gt; Until we look at the code we won&#39;t have a good idea of what k=
ind of work<br>
&gt; &gt; is<br>
&gt; &gt; involved.<br>
&gt; &gt;<br>
&gt; &gt; Strategically a Linux-PAM port might be something we might want t=
o think<br>
&gt; &gt; about long term. Tactically, any of the other options could work.=
<br>
&gt; &gt;<br>
&gt; &gt;<br>
&gt; &gt; --<br>
&gt; &gt; Cheers,<br>
&gt; &gt; Cy Schubert &lt;<a href=3D"mailto:Cy.Schubert@cschubert.com" targ=
et=3D"_blank">Cy.Schubert@cschubert.com</a>&gt;<br>
&gt; &gt; FreeBSD UNIX:=C2=A0 &lt;cy@FreeBSD.org&gt;=C2=A0 =C2=A0Web:=C2=A0=
 <a href=3D"https://FreeBSD.org" rel=3D"noreferrer" target=3D"_blank">https=
://FreeBSD.org</a><br>
&gt; &gt; NTP:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&lt;<a href=3D"mailt=
o:cy@nwtime.org" target=3D"_blank">cy@nwtime.org</a>&gt;=C2=A0 =C2=A0 Web:=
=C2=A0 <a href=3D"https://nwtime.org" rel=3D"noreferrer" target=3D"_blank">=
https://nwtime.org</a><br>;
&gt; &gt;<br>
&gt; &gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0The need of the many outweighs t=
he greed of the few.<br>
&gt; &gt;<br>
&gt; &gt;<br>
&gt; &gt; In message &lt;<a href=3D"mailto:202112301701.1BUH1dji009235@slip=
py.cwsent.com" target=3D"_blank">202112301701.1BUH1dji009235@slippy.cwsent.=
com</a>&gt;, Cy Schubert<br>
&gt; &gt; writes:<br>
&gt; &gt; &gt; No. It&#39;s a bunch of inline macros that perform memory an=
d other<br>
&gt; &gt; functions.<br>
&gt; &gt; &gt; All could have been made to be actual functions. On my Fedor=
a VM at $JOB<br>
&gt; &gt; &gt; they&#39;re part of the pam-devel.rpm.<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt; --<br>
&gt; &gt; &gt; Cheers,<br>
&gt; &gt; &gt; Cy Schubert &lt;<a href=3D"mailto:Cy.Schubert@cschubert.com"=
 target=3D"_blank">Cy.Schubert@cschubert.com</a>&gt;<br>
&gt; &gt; &gt; FreeBSD UNIX:=C2=A0 &lt;cy@FreeBSD.org&gt;=C2=A0 =C2=A0Web:=
=C2=A0 <a href=3D"https://FreeBSD.org" rel=3D"noreferrer" target=3D"_blank"=
>https://FreeBSD.org</a><br>;
&gt; &gt; &gt; NTP:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&lt;<a href=3D"=
mailto:cy@nwtime.org" target=3D"_blank">cy@nwtime.org</a>&gt;=C2=A0 =C2=A0 =
Web:=C2=A0 <a href=3D"https://nwtime.org" rel=3D"noreferrer" target=3D"_bla=
nk">https://nwtime.org</a><br>;
&gt; &gt; &gt;<br>
&gt; &gt; &gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0The need of the many outweighs the=
 greed of the few.<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt; In message<br>
&gt; &gt; &lt;CADRZFmrE8avprf7NZPcU+tbsgVBzk9=3Dqp4zHKgxLXSOK60QQQw@mail.gm=
ail.c<br>
&gt; &gt; &gt; om&gt;<br>
&gt; &gt; &gt; , Eric Turgeon writes:<br>
&gt; &gt; &gt; &gt; --00000000000063b43405d45dfc6d<br>
&gt; &gt; &gt; &gt; Content-Type: text/plain; charset=3D&quot;UTF-8&quot;<b=
r>
&gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; Do we have an equivalent of security/_pam_macros.h?<br>
&gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; *Eric Turgeon*<br>
&gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; On Wed, Dec 29, 2021 at 11:42 PM Cy Schubert &lt;<br>
&gt; &gt; <a href=3D"mailto:Cy.Schubert@cschubert.com" target=3D"_blank">Cy=
.Schubert@cschubert.com</a>&gt;<br>
&gt; &gt; &gt; &gt; wrote:<br>
&gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; &gt; This commit only fixed a compile time error, inclu=
de file<br>
&gt; &gt; &gt; &gt; &gt; security/_pam_macros.h not found (discovered by my=
 poudriere build).<br>
&gt; &gt; &gt; &gt; &gt; security/_pam_macros is an include file found only=
 on some distros of<br>
&gt; &gt; &gt; &gt; &gt; Linux, a Linuxism. Try it without PAM enabled; the=
 file not found<br>
&gt; &gt; error<br>
&gt; &gt; &gt; &gt; &gt; may<br>
&gt; &gt; &gt; &gt; &gt; just be the beginning of a multitude of PAM issues=
.<br>
&gt; &gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; &gt; I&#39;ll try to look at it over the next couple da=
ys.<br>
&gt; &gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; &gt; --<br>
&gt; &gt; &gt; &gt; &gt; Cheers,<br>
&gt; &gt; &gt; &gt; &gt; Cy Schubert &lt;<a href=3D"mailto:Cy.Schubert@csch=
ubert.com" target=3D"_blank">Cy.Schubert@cschubert.com</a>&gt;<br>
&gt; &gt; &gt; &gt; &gt; FreeBSD UNIX:=C2=A0 &lt;cy@FreeBSD.org&gt;=C2=A0 =
=C2=A0Web:=C2=A0 <a href=3D"https://FreeBSD.org" rel=3D"noreferrer" target=
=3D"_blank">https://FreeBSD.org</a><br>;
&gt; &gt; &gt; &gt; &gt; NTP:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&lt;<=
a href=3D"mailto:cy@nwtime.org" target=3D"_blank">cy@nwtime.org</a>&gt;=C2=
=A0 =C2=A0 Web:=C2=A0 <a href=3D"https://nwtime.org" rel=3D"noreferrer" tar=
get=3D"_blank">https://nwtime.org</a><br>;
&gt; &gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; &gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0The need of the m=
any outweighs the greed of the few.<br>
&gt; &gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; &gt; In message &lt;<a href=3D"mailto:20211230110857.1c=
0ac0e19e8206cb64a040d7@dec.sakura.ne.jp" target=3D"_blank">20211230110857.1=
c0ac0e19e8206cb64a040d7@dec.sakura.ne.jp</a><br>
&gt; &gt; &gt;,<br>
&gt; &gt; &gt; &gt; &gt; Tomoaki<br>
&gt; &gt; &gt; &gt; &gt; AOKI writes:<br>
&gt; &gt; &gt; &gt; &gt; &gt; Hi.<br>
&gt; &gt; &gt; &gt; &gt; &gt; Wondered whih commit to comment but decided t=
o latest.<br>
&gt; &gt; &gt; &gt; &gt; &gt; mate-screensaver no longer opens login panel =
after upgrading from<br>
&gt; &gt; &gt; &gt; &gt; &gt; 1.26.0 to 1.26.1.<br>
&gt; &gt; &gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; &gt; &gt; Created Bug 260811 [1].<br>
&gt; &gt; &gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; &gt; &gt; [1] <a href=3D"https://bugs.freebsd.org/bugzi=
lla/show_bug.cgi?id=3D260811" rel=3D"noreferrer" target=3D"_blank">https://=
bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D260811</a><br>
&gt; &gt; &gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; &gt; &gt; &gt; The branch main has been updated by cy:<=
br>
&gt; &gt; &gt; &gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; &gt; &gt; &gt; URL:<br>
&gt; &gt; &gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; &gt;<br>
&gt; &gt; <a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3Df3caf74210=
8bb552724d4c4dae74b28" rel=3D"noreferrer" target=3D"_blank">https://cgit.Fr=
eeBSD.org/ports/commit/?id=3Df3caf742108bb552724d4c4dae74b28</a><br>
&gt; &gt; &gt; ea<br>
&gt; &gt; &gt; &gt; 26<br>
&gt; &gt; &gt; &gt; &gt; &gt; 6a6a3<br>
&gt; &gt; &gt; &gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; &gt; &gt; &gt; commit f3caf742108bb552724d4c4dae74b28ea=
266a6a3<br>
&gt; &gt; &gt; &gt; &gt; &gt; &gt; Author:=C2=A0 =C2=A0 =C2=A0Cy Schubert &=
lt;cy_at_FreeBSD.org&gt;<br>
&gt; &gt; &gt; &gt; &gt; &gt; &gt; AuthorDate: 2021-12-29 03:12:39 +0000<br=
>
&gt; &gt; &gt; &gt; &gt; &gt; &gt; Commit:=C2=A0 =C2=A0 =C2=A0Cy Schubert &=
lt;cy_at_FreeBSD.org&gt;<br>
&gt; &gt; &gt; &gt; &gt; &gt; &gt; CommitDate: 2021-12-29 03:12:39 +0000<br=
>
&gt; &gt; &gt; &gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; &gt; &gt; &gt;=C2=A0 =C2=A0 =C2=A0x11/mate-screensaver:=
 Fix PAM build<br>
&gt; &gt; &gt; &gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; &gt; &gt; &gt;=C2=A0 =C2=A0 =C2=A0Fix build when PAM en=
abled; &lt;security/_pam_macros.h&gt; is a<br>
&gt; &gt; Linuxis<br>
&gt; &gt; &gt; m.<br>
&gt; &gt; &gt; &gt; &gt; &gt; &gt; ---<br>
&gt; &gt; &gt; &gt; &gt; &gt; &gt;=C2=A0 x11/mate-screensaver/files/patch-h=
elper_pam-helper.c | 10<br>
&gt; &gt; ++++++++++<br>
&gt; &gt; &gt; &gt; &gt; &gt; &gt;=C2=A0 1 file changed, 10 insertions(+)<b=
r>
&gt; &gt; &gt; &gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; &gt; &gt; &gt; diff --git a/x11/mate-screensaver/files/=
patch-helper_pam-helper.c<br>
&gt; &gt; &gt; &gt; &gt; &gt; b/x11/mate-screensaver/files/patch-helper_pam=
-helper.c<br>
&gt; &gt; &gt; &gt; &gt; &gt; &gt; new file mode 100644<br>
&gt; &gt; &gt; &gt; &gt; &gt; &gt; index 000000000000..605141fb0e54<br>
&gt; &gt; &gt; &gt; &gt; &gt; &gt; --- /dev/null<br>
&gt; &gt; &gt; &gt; &gt; &gt; &gt; +++ b/x11/mate-screensaver/files/patch-h=
elper_pam-helper.c<br>
&gt; &gt; &gt; &gt; &gt; &gt; &gt; _at__at_ -0,0 +1,10 _at__at_<br>
&gt; &gt; &gt; &gt; &gt; &gt; &gt; +--- helper/pam-helper.c.orig=C2=A0 =C2=
=A0 =C2=A0 =C2=A02021-11-15<br>
&gt; &gt; 14:28:47.000000000 -08<br>
&gt; &gt; &gt; 00<br>
&gt; &gt; &gt; &gt; &gt; &gt; &gt; ++++ helper/pam-helper.c=C2=A0 =C2=A0 20=
21-12-28 19:09:39.501645000 -0800<br>
&gt; &gt; &gt; &gt; &gt; &gt; &gt; +_at__at_ -33,7 +33,6 _at__at_<br>
&gt; &gt; &gt; &gt; &gt; &gt; &gt; +=C2=A0 */<br>
&gt; &gt; &gt; &gt; &gt; &gt; &gt; +<br>
&gt; &gt; &gt; &gt; &gt; &gt; &gt; + #include &lt;security/pam_appl.h&gt;<b=
r>
&gt; &gt; &gt; &gt; &gt; &gt; &gt; +-#include &lt;security/_pam_macros.h&gt=
;<br>
&gt; &gt; &gt; &gt; &gt; &gt; &gt; +<br>
&gt; &gt; &gt; &gt; &gt; &gt; &gt; + #include &lt;sys/types.h&gt;<br>
&gt; &gt; &gt; &gt; &gt; &gt; &gt; + #include &lt;stdarg.h&gt;<br>
&gt; &gt; &gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; &gt; &gt; --<br>
&gt; &gt; &gt; &gt; &gt; &gt; Tomoaki AOKI=C2=A0 =C2=A0 &lt;<a href=3D"mail=
to:junchoon@dec.sakura.ne.jp" target=3D"_blank">junchoon@dec.sakura.ne.jp</=
a>&gt;<br>
&gt; &gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; --00000000000063b43405d45dfc6d<br>
&gt; &gt; &gt; &gt; Content-Type: text/html; charset=3D&quot;UTF-8&quot;<br=
>
&gt; &gt; &gt; &gt; Content-Transfer-Encoding: quoted-printable<br>
&gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; &lt;div dir=3D3D&quot;ltr&quot;&gt;&lt;div&gt;Do we hav=
e an equivalent of<br>
&gt; &gt; security/_pam_macros.h?&lt;/<br>
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt; div&gt;&lt;div&gt;&lt;br&gt;&lt;/div&gt;&lt;div&gt;&lt;=
div&gt;&lt;div dir=3D3D&quot;ltr&quot;<br>
&gt; &gt; class=3D3D&quot;gmail_signature&quot; dat<br>
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt; a-smartmail=3D3D&quot;gmail_signature&quot;&gt;&lt;div =
dir=3D3D&quot;ltr&quot;&gt;&lt;div&gt;&lt;div<br>
&gt; &gt; dir=3D3D&quot;ltr&quot;&gt;&lt;div<br>
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt; &gt;&lt;div dir=3D3D&quot;ltr&quot;&gt;&lt;div&gt;&lt;d=
iv dir=3D3D&quot;ltr&quot;&gt;&lt;div dir=3D3D&quot;ltr&quot;&gt;&lt;span&g=
t;&lt;font<br>
&gt; &gt; color=3D<br>
&gt; &gt; &gt; &gt; =3D3D&quot;#888888&quot;&gt;&lt;font&gt;&lt;font color=
=3D3D&quot;#000000&quot;&gt;&lt;b&gt;Eric<br>
&gt; &gt; Turgeon&lt;/b&gt;&lt;/font&gt;&lt;/font<br>
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt;&lt;/font&gt;&lt;/span&gt;&lt;span&gt;&lt;/span&gt;&lt;cite&g=
t;&lt;/cite&gt;&lt;br&gt;&lt;/div&gt;&lt;span&gt;&lt;/span&gt;&lt;/div&gt;&=
lt;/div<br>
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt; &gt;&lt;/div&gt;&lt;/div&gt;&lt;/div&gt;&lt;/div&gt;&lt=
;/div&gt;&lt;/div&gt;&lt;/div&gt;&lt;br&gt;&lt;/div&gt;&lt;/div&gt;&lt;br&g=
t;&lt;div<br>
&gt; &gt; class=3D<br>
&gt; &gt; &gt; &gt; =3D3D&quot;gmail_quote&quot;&gt;&lt;div dir=3D3D&quot;l=
tr&quot; class=3D3D&quot;gmail_attr&quot;&gt;On Wed, Dec 29,<br>
&gt; &gt; 2021<br>
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt;=C2=A0 at 11:42 PM Cy Schubert &amp;lt;&lt;a href=3D3D&q=
uot;mailto:<br>
&gt; &gt; <a href=3D"mailto:Cy.Schubert@cschubert.com" target=3D"_blank">Cy=
.Schubert@cschubert.com</a>&quot;&gt;C<br>
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt; <a href=3D"mailto:y.Schubert@cschubert.com" target=3D"_=
blank">y.Schubert@cschubert.com</a>&lt;/a&gt;&amp;gt; wrote:&lt;br&gt;&lt;/=
div&gt;&lt;blockquote<br>
&gt; &gt; class=3D3D&quot;gmail<br>
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt; _quote&quot; style=3D3D&quot;margin:0px 0px 0px 0.8ex;b=
order-left:1px solid<br>
&gt; &gt; rgb(204,204<br>
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt; ,204);padding-left:1ex&quot;&gt;This commit only fixed =
a compile time error,<br>
&gt; &gt; includ<br>
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt; e file &lt;br&gt;<br>
&gt; &gt; &gt; &gt; security/_pam_macros.h not found (discovered by my poud=
riere build).<br>
&gt; &gt; &lt;br&gt;<br>
&gt; &gt; &gt; &gt; security/_pam_macros is an include file found only on s=
ome distros of<br>
&gt; &gt; &lt;br&gt;<br>
&gt; &gt; &gt; &gt; Linux, a Linuxism. Try it without PAM enabled; the file=
 not found<br>
&gt; &gt; error may<br>
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt;=C2=A0 &lt;br&gt;<br>
&gt; &gt; &gt; &gt; just be the beginning of a multitude of PAM issues.&lt;=
br&gt;<br>
&gt; &gt; &gt; &gt; &lt;br&gt;<br>
&gt; &gt; &gt; &gt; I&amp;#39;ll try to look at it over the next couple day=
s.&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &lt;br&gt;<br>
&gt; &gt; &gt; &gt; &lt;br&gt;<br>
&gt; &gt; &gt; &gt; -- &lt;br&gt;<br>
&gt; &gt; &gt; &gt; Cheers,&lt;br&gt;<br>
&gt; &gt; &gt; &gt; Cy Schubert &amp;lt;&lt;a href=3D3D&quot;mailto:<a href=
=3D"mailto:Cy.Schubert@cschubert.com" target=3D"_blank">Cy.Schubert@cschube=
rt.com</a>&quot;<br>
&gt; &gt; target=3D3D&quot;_bla<br>
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt; nk&quot;&gt;<a href=3D"mailto:Cy.Schubert@cschubert.com=
" target=3D"_blank">Cy.Schubert@cschubert.com</a>&lt;/a&gt;&amp;gt;&lt;br&g=
t;<br>
&gt; &gt; &gt; &gt; FreeBSD UNIX:=3DC2=3DA0 &amp;lt;cy@FreeBSD.org&amp;gt;=
=3DC2=3DA0 =3DC2=3DA0Web:=3DC2=3DA0 &lt;a<br>
&gt; &gt; href=3D<br>
&gt; &gt; &gt; &gt; =3D3D&quot;<a href=3D"https://FreeBSD.org" rel=3D"noref=
errer" target=3D"_blank">https://FreeBSD.org</a>&quot; rel=3D3D&quot;norefe=
rrer&quot; target=3D3D&quot;_blank&quot;&gt;<br>
&gt; &gt; <a href=3D"https://FreeB" rel=3D"noreferrer" target=3D"_blank">ht=
tps://FreeB</a><br>
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt; SD.org&lt;/a&gt;&lt;br&gt;<br>
&gt; &gt; &gt; &gt; NTP:=3DC2=3DA0 =3DC2=3DA0 =3DC2=3DA0 =3DC2=3DA0 =3DC2=
=3DA0 =3DC2=3DA0&amp;lt;&lt;a href=3D3D&quot;mailto:<br>
&gt; &gt; cy@nwtim<br>
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt; <a href=3D"http://e.org" rel=3D"noreferrer" target=3D"_=
blank">e.org</a>&quot; target=3D3D&quot;_blank&quot;&gt;<a href=3D"mailto:c=
y@nwtime.org" target=3D"_blank">cy@nwtime.org</a>&lt;/a&gt;&amp;gt;=3DC2=3D=
A0 =3DC2=3DA0<br>
&gt; &gt; Web:=3DC2=3DA0 &lt;a h<br>
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt; ref=3D3D&quot;<a href=3D"https://nwtime.org" rel=3D"nor=
eferrer" target=3D"_blank">https://nwtime.org</a>&quot; rel=3D3D&quot;noref=
errer&quot; target=3D3D&quot;_blank&quot;&gt;<br>
&gt; &gt; <a href=3D"https://nwt" rel=3D"noreferrer" target=3D"_blank">http=
s://nwt</a><br>
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt; <a href=3D"http://ime.org" rel=3D"noreferrer" target=3D=
"_blank">ime.org</a>&lt;/a&gt;&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &lt;br&gt;<br>
&gt; &gt; &gt; &gt; =3DC2=3DA0 =3DC2=3DA0 =3DC2=3DA0 =3DC2=3DA0 The need of=
 the many outweighs the greed<br>
&gt; &gt; of the<br>
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt;=C2=A0 few.&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &lt;br&gt;<br>
&gt; &gt; &gt; &gt; &lt;br&gt;<br>
&gt; &gt; &gt; &gt; In message &amp;lt;&lt;a href=3D3D&quot;mailto:<br>
&gt; &gt; 20211230110857.1c0ac0e19e8206cb64a040d7@de<br>
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt; <a href=3D"http://c.sakura.ne.jp" rel=3D"noreferrer" ta=
rget=3D"_blank">c.sakura.ne.jp</a>&quot;<br>
&gt; &gt; target=3D3D&quot;_blank&quot;&gt;20211230110857.1c0ac0e19e8206cb6=
4a040d7@d<br>
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt; <a href=3D"http://ec.sakura.ne.jp" rel=3D"noreferrer" t=
arget=3D"_blank">ec.sakura.ne.jp</a>&lt;/a&gt;&amp;gt;, &lt;br&gt;<br>
&gt; &gt; &gt; &gt; Tomoaki&lt;br&gt;<br>
&gt; &gt; &gt; &gt; AOKI writes:&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; Hi.&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; Wondered whih commit to comment but decided to=
 latest.&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; mate-screensaver no longer opens login panel a=
fter upgrading<br>
&gt; &gt; from&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; 1.26.0 to 1.26.1.&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt;&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; Created Bug 260811 [1].&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt;&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; [1] &lt;a href=3D3D&quot;<br>
&gt; &gt; <a href=3D"https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D3D=
260" rel=3D"noreferrer" target=3D"_blank">https://bugs.freebsd.org/bugzilla=
/show_bug.cgi?id=3D3D260</a><br>
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt; 811&quot; rel=3D3D&quot;noreferrer&quot; target=3D3D&qu=
ot;_blank&quot;&gt;<br>
&gt; &gt; <a href=3D"https://bugs.freebsd.org/bugzilla" rel=3D"noreferrer" =
target=3D"_blank">https://bugs.freebsd.org/bugzilla</a><br>;
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt; /show_bug.cgi?id=3D3D260811&lt;/a&gt;&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt;&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt;&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt; The branch main has been updated by c=
y:&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt; &lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt; URL:&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &lt;a href=3D3D&quot;<br>
&gt; &gt; <a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3D3Df3caf742=
108bb55" rel=3D"noreferrer" target=3D"_blank">https://cgit.FreeBSD.org/port=
s/commit/?id=3D3Df3caf742108bb55</a><br>
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt; 2724d4c4dae74b28ea26&quot; rel=3D3D&quot;noreferrer&quo=
t; target=3D3D&quot;_blank&quot;&gt;<br>
&gt; &gt; <a href=3D"https://cgit.Fre" rel=3D"noreferrer" target=3D"_blank"=
>https://cgit.Fre</a><br>;
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt; eBSD.org/ports/commit/?id=3D3Df3caf742108bb552724d4c4da=
e74b28ea26&lt;/a&gt;&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; 6a6a3&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt; &lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt; commit f3caf742108bb552724d4c4dae74b2=
8ea266a6a3&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt; Author:=3DC2=3DA0 =3DC2=3DA0 =3DC2=3D=
A0Cy Schubert<br>
&gt; &gt; &amp;lt;cy_at_FreeBSD.org&amp;gt;&lt;<br>
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt; br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt; AuthorDate: 2021-12-29 03:12:39 +0000=
&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt; Commit:=3DC2=3DA0 =3DC2=3DA0 =3DC2=3D=
A0Cy Schubert<br>
&gt; &gt; &amp;lt;cy_at_FreeBSD.org&amp;gt;&lt;<br>
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt; br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt; CommitDate: 2021-12-29 03:12:39 +0000=
&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt; &lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt;=3DC2=3DA0 =3DC2=3DA0 =3DC2=3DA0x11/ma=
te-screensaver: Fix PAM build&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt;=3DC2=3DA0 =3DC2=3DA0 =3DC2=3DA0&lt;br=
&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt;=3DC2=3DA0 =3DC2=3DA0 =3DC2=3DA0Fix bu=
ild when PAM enabled;<br>
&gt; &gt; &amp;lt;security/_pam_<br>
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt; macros.h&amp;gt; is a Linuxism.&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt; ---&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt;=3DC2=3DA0 x11/mate-screensaver/files/=
patch-helper_pam-helper.c |<br>
&gt; &gt; 10 +<br>
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt; +++++++++&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt;=3DC2=3DA0 1 file changed, 10 insertio=
ns(+)&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt; &lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt; diff --git<br>
&gt; &gt; a/x11/mate-screensaver/files/patch-helper_pam-helper.c<br>
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt; &lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; b/x11/mate-screensaver/files/patch-helper_pam-=
helper.c&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt; new file mode 100644&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt; index 000000000000..605141fb0e54&lt;b=
r&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt; --- /dev/null&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt; +++<br>
&gt; &gt; b/x11/mate-screensaver/files/patch-helper_pam-helper.c&lt;br&gt;<=
br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt; _at__at_ -0,0 +1,10 _at__at_&lt;br&gt=
;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt; +--- helper/pam-helper.c.orig=3DC2=3D=
A0 =3DC2=3DA0 =3DC2=3DA0<br>
&gt; &gt; =3DC2=3DA02021-11-1<br>
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt; 5 14:28:47.000000000 -0800&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt; ++++ helper/pam-helper.c=3DC2=3DA0 =
=3DC2=3DA0 2021-12-28<br>
&gt; &gt; 19:09:39.5016450<br>
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt; 00 -0800&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt; +_at__at_ -33,7 +33,6 _at__at_&lt;br&=
gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt; +=3DC2=3DA0 */&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt; + &lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt; + #include &amp;lt;security/pam_appl.=
h&amp;gt;&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt; +-#include &amp;lt;security/_pam_macr=
os.h&amp;gt;&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt; + &lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt; + #include &amp;lt;sys/types.h&amp;gt=
;&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; &amp;gt; + #include &amp;lt;stdarg.h&amp;gt;&l=
t;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt;&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; -- &lt;br&gt;<br>
&gt; &gt; &gt; &gt; &amp;gt; Tomoaki AOKI=3DC2=3DA0 =3DC2=3DA0 &amp;lt;&lt;=
a href=3D3D&quot;mailto:<br>
&gt; &gt; <a href=3D"mailto:junchoon@dec.sakura.ne" target=3D"_blank">junch=
oon@dec.sakura.ne</a><br>
&gt; &gt; &gt; =3D<br>
&gt; &gt; &gt; &gt; .jp&quot; target=3D3D&quot;_blank&quot;&gt;<a href=3D"m=
ailto:junchoon@dec.sakura.ne.jp" target=3D"_blank">junchoon@dec.sakura.ne.j=
p</a>&lt;/a&gt;&amp;gt;&lt;br&gt;<br>
&gt; &gt; &gt; &gt; &lt;br&gt;<br>
&gt; &gt; &gt; &gt; &lt;br&gt;<br>
&gt; &gt; &gt; &gt; &lt;/blockquote&gt;&lt;/div&gt;<br>
&gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; --00000000000063b43405d45dfc6d--<br>
&gt; &gt; &gt;<br>
&gt; &gt;<br>
&gt; &gt;<br>
&gt; &gt;<br>
<br>
<br>
-- <br>
Tomoaki AOKI=C2=A0 =C2=A0 &lt;<a href=3D"mailto:junchoon@dec.sakura.ne.jp" =
target=3D"_blank">junchoon@dec.sakura.ne.jp</a>&gt;<br>
</blockquote></div>
</blockquote></div>

--000000000000bcd0f505d4792923--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADRZFmpTOMeR4%2Bk2Z7nr3j_d6-%2BUMP-tZ-7V48FszQwiKNEQ3g>