Date: Fri, 6 Apr 2007 09:39:35 +0400 From: Andrey Chernov <ache@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Pawel Jakub Dawidek <pjd@FreeBSD.org>, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/include stdio.h src/lib/libc/sys lseek.2 pathconf.2 src/sys/kern vfs_syscalls.c src/sys/sys filio.h unistd.h Message-ID: <20070406053934.GA84722@nagual.pp.ru> In-Reply-To: <20070406115326.A43678@delplex.bde.org> References: <200704052110.l35LAsXH013966@repoman.freebsd.org> <20070406115326.A43678@delplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Apr 06, 2007 at 11:58:55AM +1000, Bruce Evans wrote: > On Thu, 5 Apr 2007, Pawel Jakub Dawidek wrote: > > >pjd 2007-04-05 21:10:54 UTC > > > > FreeBSD src repository > > > > Modified files: > > include stdio.h > > lib/libc/sys lseek.2 pathconf.2 > > sys/kern vfs_syscalls.c > > sys/sys filio.h unistd.h > > Log: > > Implement SEEK_DATA and SEEK_HOLE extensions to lseek(2) as found in > > OpenSolaris. For more information please refer to: > > > > http://blogs.sun.com/bonwick/entry/seek_hole_and_seek_data > > These are just namespace pollution in stdio.h. stdio (fseek()) doesn't > support them, and the hack of declaring lseek() in stdio.h should not > be extended to new interfaces. If stdio ever supports them, then they > would need to be declared under a visibility ifdef (not #ifdef self). I agree. They must be implemented in fseek.c code first before adding them to stdio.h and ifdefed with proper *_VISIBLE tags in all places. Perhaps new __CDDL_VISIBLE tag required for it. -- http://ache.pp.ru/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070406053934.GA84722>