Date: Fri, 16 Mar 2007 12:51:57 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Ceri Davies <ceri@submonkey.net> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libufs type.c Message-ID: <20070316115157.GA6440@garage.freebsd.pl> In-Reply-To: <20070316111612.GZ53780@submonkey.net> References: <200703160313.l2G3DTHP048236@repoman.freebsd.org> <20070316111612.GZ53780@submonkey.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Fri, Mar 16, 2007 at 11:16:12AM +0000, Ceri Davies wrote: > On Fri, Mar 16, 2007 at 03:13:29AM +0000, Pawel Jakub Dawidek wrote: > > pjd 2007-03-16 03:13:29 UTC > > > > FreeBSD src repository > > > > Modified files: > > lib/libufs type.c > > Log: > > The ufs_disk_fillout(3) can take special device name (with or without /dev/ > > prefix) as an argument and mount point path. At the end it has to find > > device name file system is stored on, which means when mount point path is > > given, it tries to look into /etc/fstab and find special device > > corresponding to the given mount point. This is not perfect, because it > > doesn't handle the case when file system is mounted by hand and mount point > > is given as an argument. > > > > I found this problem while trying to use snapinfo(8), which passes mount > > points to the ufs_disk_fillout(3) function, but I had file system mounted > > manually, so snapinfo(8) was exiting with the error below: > > > > ufs_disk_fillout: No such file or directory > > > > I modified libufs(3) to handle those arguments (the order is important): > > > > 1. special device with /dev/ prefix > > 2. special device without /dev/ prefix > > 3. mount point listed in /etc/fstab, directory exists > > 4. mount point listed in /etc/fstab, directory doesn't exist > > 5. mount point of a file system mounted by hand > > Is there any chance that this, or the related snapinfo commit, fixes > PR 94635? I'm quite sure this should be fixed now, yes. Can we ask submitter to retest? -- Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFF+oTdForvXbEpPzQRAoRhAKC9N2G6FlvGEi0SPxc19AfIggx7RQCfXnRa u7qhrDessFLTC/xzm3npZ3U= =C5yj -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070316115157.GA6440>