Date: Sat, 26 Mar 2011 07:12:05 -0700 (PDT) From: "Pedro F. Giffuni" <giffunip@tutopia.com> To: Kostik Belousov <kostikbel@gmail.com> Cc: Mikolaj Golub <trociny@freebsd.org>, freebsd-fs@freebsd.org Subject: Re: kern/152079: [msdosfs] [patch] Small cleanups from the other NetBSD/OpenBSD Message-ID: <553011.63188.qm@web113509.mail.gq1.yahoo.com> In-Reply-To: <20110326120421.GX78089@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--- On Sat, 3/26/11, Kostik Belousov <kostikbel@gmail.com> wrote:
...
> Ok, after rereading the code, I do not believe that we need
> the change. The doscheckpath() does vput() on tdvp, and tvp
> is vput'ed right before line 1083, so jumping to the label
> `bad' instead of `out' will only result in the lock
> assertion being fired.
>
> Also, the msdosfs mount correctly unmounts after the
> attempt to perform a rename that doscheckpath() banned.
> This is additional evidence supporting my point.
>
> The question is, why did you decided that the fix is needed
> for FreeBSD ?
>
Defensive programming. On NetBSD this apparently started
causing problems for unknown reasons, and doing the change
doesn't have any ill effect on FreeBSD.
I am OK, if you want to close the PR though, and thanks for
doing the complete research.
Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?553011.63188.qm>