Date: Tue, 5 Nov 2013 17:52:29 -0800 From: Garrett Cooper <yaneurabeya@gmail.com> To: Julio Merino <julio@meroh.net> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>, Rui Paulo <rpaulo@fnop.net> Subject: Re: Fixing the build with TESTS Message-ID: <CAGHfRMDLCKvTXpYUYQWZu64qpeqATkzwH_Yc7%2BZRXSh%2BxWyiNw@mail.gmail.com> In-Reply-To: <CADyfeQW4GwhKgg4P8OWELnGWvDO8mvSjjo7Og3WMk2uxAGBGoA@mail.gmail.com> References: <CADyfeQW4GwhKgg4P8OWELnGWvDO8mvSjjo7Og3WMk2uxAGBGoA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--001a1133158edae0f204ea7866d2 Content-Type: text/plain; charset=ISO-8859-1 On Tue, Nov 5, 2013 at 4:17 PM, Julio Merino <julio@meroh.net> wrote: > Hello, > > The previous changes to enable the installation of tests broke the > build and is the reason why Rui had to default the TESTS knob to 'no'. > The reason for the breakage is the following: > > When buildworld starts by building the basic "bootstrap" libraries, it > does a "make all" within various lib/* directories, including > libcrypt. libcrypt had tests added to it, which means that "make all" > recursed into the tests directory and attempted to build them. But, at > that point, the atf libraries had not yet been built. I did not > encounter this issue because I'm running builds with MK_CLEAN=no (yup, > lesson learned). > > I think it's wrong for this stage of buildworld to attempt building > tests at all. atf is just one of the many dependencies we'd encounter, > and we should not try to build all dependencies upfront... because we > cannot. (Just imagine when libc starts getting tests.) > > The fix-build-bootstrap.patch attached attempts to correct this by > explicitly disabling the build of any tests during the initial build > of the bootstrap components. I'm not sure this patch is nice enough, > although it follows the style of various other related knobs; if you > have better ideas, please share. > > Additionally, we will encounter similar issues once we have tests that > use C++ (which we will, if only because of libatf-c++'s tests), so we > should also do what fix-build-atf-cxx.patch proposes. > > Thoughts? I fixed this on my branch some time ago. See this patch for more details (from http://lists.freebsd.org/pipermail/freebsd-toolchain/2013-April/000804.html ) : http://lists.freebsd.org/pipermail/freebsd-toolchain/attachments/20130424/c44daa61/attachment.obj . If you change the former patch to refer to lib/atf instead of lib/atf/libatf-c, things will just work too is the order is properly specified in lib/atf :). I've attached entire up-to-date patch set, just for simplicity. Thanks! -Garrett --001a1133158edae0f204ea7866d2 Content-Type: application/octet-stream; name="bsd.own.mk-patch" Content-Disposition: attachment; filename="bsd.own.mk-patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hnnwuseh2 LS0tIHNoYXJlL21rL2JzZC5vd24ubWsJMjAxMy0xMS0wMyAxMzozMjoyNi4wMDAwMDAwMDAgLTA4 MDAKKysrIHNoYXJlL21rL2JzZC5vd24ubWsJMjAxMy0xMS0wNCAxNTo0OTo0My4wMDAwMDAwMDAg LTA4MDAKQEAgLTM3OSw2ICszODMsMTQgQEAKICAgICBURVNUUyBcCiAgICAgVVNCX0dBREdFVF9F WEFNUExFUwogCisjIGJzZC50ZXN0Lm1rIGRvZXNuJ3Qgd29yayB3aXRoICFibWFrZS4gQWxzbyBk b24ndCBidWlsZCB0ZXN0cyBpZiBOT19URVNUUyBpcworIyBkZWZpbmVkOyB0aGlzIGlzIGZvciBi dWlsZHdvcmxkIGFuZCBlbHNld2hlcmUgKHBvcnRzIHBvdGVudGlhbGx5KS4KKy5pZiAhZGVmaW5l ZChOT19URVNUUykKK19fREVGQVVMVF9OT19PUFRJT05TKz1URVNUUworLmVsc2UKK01LX1RFU1RT Oj0Jbm8KKy5lbmRpZgorCiAjCiAjIERlZmF1bHQgYmVoYXZpb3VyIG9mIHNvbWUgb3B0aW9ucyBk ZXBlbmRzIG9uIHRoZSBhcmNoaXRlY3R1cmUuICBVbmZvcnR1bmF0ZWx5CiAjIHRoaXMgbWVhbnMg dGhhdCB3ZSBoYXZlIHRvIHRlc3QgVEFSR0VUX0FSQ0ggKHRoZSBidWlsZHdvcmxkIGNhc2UpIGFz IHdlbGwK --001a1133158edae0f204ea7866d2 Content-Type: application/octet-stream; name="bsd.subdir.mk-patch" Content-Disposition: attachment; filename="bsd.subdir.mk-patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hnnwuset3 LS0tIC91c3Ivc3JjLnN2bi9zaGFyZS9tay9ic2Quc3ViZGlyLm1rCTIwMTMtMTEtMDMgMTM6MzI6 MjYuMDAwMDAwMDAwIC0wODAwCisrKyBzaGFyZS9tay9ic2Quc3ViZGlyLm1rCTIwMTMtMTEtMDQg MTU6NDk6NDMuMDAwMDAwMDAwIC0wODAwCkBAIC00Myw2ICs0MywxMSBAQAogLmVuZGZvcgogLmVu ZGlmCiAKKy5pZiAke01LX1RFU1RTfSAhPSAibm8iICYmIGV4aXN0cygkey5DVVJESVJ9L3Rlc3Rz L01ha2VmaWxlKQorU1VCRElSKz0gdGVzdHMKK1NVQkRJUl9UQVJHRVRTKz0gdGVzdAorLmVuZGlm CisKIF9TVUJESVI6IC5VU0UgLk1BS0UKIC5pZiBkZWZpbmVkKFNVQkRJUikgJiYgIWVtcHR5KFNV QkRJUikgJiYgIWRlZmluZWQoTk9fU1VCRElSKQogCUAke18rX31zZXQgLWU7IGZvciBlbnRyeSBp biAke1NVQkRJUn07IGRvIFwK --001a1133158edae0f204ea7866d2 Content-Type: application/octet-stream; name="Makefile.inc1-patch" Content-Disposition: attachment; filename="Makefile.inc1-patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hnnwusf24 LS0tIE1ha2VmaWxlLmluYzEJMjAxMy0xMS0wNCAxNTozOTozOS4wMDAwMDAwMDAgLTA4MDAKKysr IE1ha2VmaWxlLmluYzEJMjAxMy0xMS0wNCAxNTo1MTowMy4wMDAwMDAwMDAgLTA4MDAKQEAgLTkx LDYgKzkyLDkgQEAKIC5pZiAke01LX09GRUR9ICE9ICJubyIKIFNVQkRJUis9Y29udHJpYi9vZmVk CiAuZW5kaWYKKy5pZiAke01LX1RFU1RTfSAhPSAibm8iCitTVUJESVIrPXRlc3RzCisuZW5kaWYK ICMKICMgV2UgbXVzdCBkbyBldGMvIGxhc3QgZm9yIGluc3RhbGwvZGlzdHJpYnV0ZSB0byB3b3Jr LgogIwpAQCAtMjQ2LDcgKzI1MCw3IEBACiAJCVNTUF9DRkxBR1M9IFwKIAkJLURXSVRIT1VUX0hU TUwgLURXSVRIT1VUX0lORk8gLUROT19MSU5UIC1EV0lUSE9VVF9NQU4gXAogCQktRE5PX1BJQyAt RE5PX1BST0ZJTEUgLUROT19TSEFSRUQgXAotCQktRE5PX0NQVV9DRkxBR1MgLUROT19XQVJOUyAt RE5PX0NURiAtREVBUkxZX0JVSUxECisJCS1ETk9fQ1BVX0NGTEFHUyAtRE5PX1dBUk5TIC1ETk9f Q1RGIC1ERUFSTFlfQlVJTEQgLUROT19URVNUUwogCiAjIGJ1aWxkLXRvb2xzIHN0YWdlCiBUTUFL RT0JCU1BS0VPQkpESVJQUkVGSVg9JHtPQkpUUkVFfSBcCkBAIC0yNTYsMTIgKzI2MCwxMiBAQAog CQlCT09UU1RSQVBQSU5HPSR7T1NSRUxEQVRFfSBcCiAJCVNTUF9DRkxBR1M9IFwKIAkJLUROT19M SU5UIFwKLQkJLUROT19DUFVfQ0ZMQUdTIC1ETk9fV0FSTlMgLUROT19DVEYgLURFQVJMWV9CVUlM RAorCQktRE5PX0NQVV9DRkxBR1MgLUROT19XQVJOUyAtRE5PX0NURiAtREVBUkxZX0JVSUxEIC1E Tk9fVEVTVFMKIAogIyBjcm9zcy10b29scyBzdGFnZQogWE1BS0U9CQlUT09MU19QUkVGSVg9JHtX T1JMRFRNUH0gJHtCTUFLRX0gXAogCQlUQVJHRVQ9JHtUQVJHRVR9IFRBUkdFVF9BUkNIPSR7VEFS R0VUX0FSQ0h9IFwKLQkJLURXSVRIT1VUX0dEQgorCQktRFdJVEhPVVRfR0RCIC1ETk9fVEVTVFMK IAogIyB3b3JsZCBzdGFnZQogV01BS0VFTlY9CSR7Q1JPU1NFTlZ9IFwKQEAgLTM5OSw3ICs0MDMs OCBAQAogCQktRExJQlJBUklFU19PTkxZIFwKIAkJLUROT19DUFVfQ0ZMQUdTIFwKIAkJLUROT19D VEYgXAotCQktRE5PX0xJTlQKKwkJLUROT19MSU5UIFwKKwkJLUROT19URVNUUwogCiBMSUIzMldN QUtFPQkke0xJQjMyV01BS0VFTlZ9ICR7TUFLRX0gJHtMSUIzMldNQUtFRkxBR1N9IFwKIAkJLURX SVRIT1VUX01BTiAtRFdJVEhPVVRfSU5GTyAtRFdJVEhPVVRfSFRNTApAQCAtNTYzLDcgKzU2Niw3 IEBACiAJQGVjaG8gIi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tIgogCSR7XytffWNkICR7LkNVUkRJUn07IFwKIAkgICAgJHtXTUFL RX0gLUROT19GU0NIRyAtRFdJVEhPVVRfSFRNTCAtRFdJVEhPVVRfSU5GTyAtRE5PX0xJTlQgXAot CSAgICAtRFdJVEhPVVRfTUFOIC1ETk9fUFJPRklMRSBsaWJyYXJpZXMKKwkgICAgLURXSVRIT1VU X01BTiAtRE5PX1BST0ZJTEUgLUROT19URVNUUyBsaWJyYXJpZXMKIF9kZXBlbmQ6CiAJQGVjaG8K IAlAZWNobyAiLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0iCkBAIC0xNDg3LDcgKzE0NzgsNyBAQAogCQkke19rZXJiZXJvczVfbGli X2xpYmh4NTA5fSAke19rZXJiZXJvczVfbGliX2xpYmtyYjV9IFwKIAkJJHtfa2VyYmVyb3M1X2xp Yl9saWJyb2tlbn0gXAogCQkke19rZXJiZXJvczVfbGliX2xpYndpbmR9IFwKLQkJJHtfbGliX2F0 Zl9saWJhdGZfY30gXAorCQkke19saWJfYXRmfSBcCiAJCWxpYi9saWJiejIgJHtfbGliY29tX2Vy cn0gbGliL2xpYmNyeXB0IFwKIAkJbGliL2xpYmVsZiBsaWIvbGliZXhwYXQgXAogCQkke19saWJf bGliZ3NzYXBpfSAke19saWJfbGliaXB4fSBcCkBAIC0xNTAyLDcgKzE0OTMsNyBAQAogCQkke19z ZWN1cmVfbGliX2xpYnNzaH0gJHtfc2VjdXJlX2xpYl9saWJzc2x9CiAKIC5pZiAke01LX0FURn0g IT0gIm5vIgotX2xpYl9hdGZfbGliYXRmX2M9CWxpYi9hdGYvbGliYXRmLWMKK19saWJfYXRmPQls aWIvYXRmCiAuZW5kaWYKIAogLmlmICR7TUtfTElCVEhSfSAhPSAibm8iCkBAIC0xODY2LDcgKzE4 NTksNyBAQAogCiBOT0ZVTj0tRE5PX0ZTQ0hHIC1EV0lUSE9VVF9IVE1MIC1EV0lUSE9VVF9JTkZP IC1ETk9fTElOVCBcCiAJLURXSVRIT1VUX01BTiAtRFdJVEhPVVRfTkxTIC1ETk9fUFJPRklMRSBc Ci0JLURXSVRIT1VUX0tFUkJFUk9TIC1EV0lUSE9VVF9SRVNDVUUgLUROT19XQVJOUyBcCisJLURX SVRIT1VUX0tFUkJFUk9TIC1EV0lUSE9VVF9SRVNDVUUgLUROT19URVNUUyAtRE5PX1dBUk5TIFwK IAlUQVJHRVQ9JHtYREVWfSBUQVJHRVRfQVJDSD0ke1hERVZfQVJDSH0gXAogCUNQVVRZUEU9JHtY REVWX0NQVVRZUEV9CiAK --001a1133158edae0f204ea7866d2--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMDLCKvTXpYUYQWZu64qpeqATkzwH_Yc7%2BZRXSh%2BxWyiNw>