Date: Wed, 24 Aug 2011 07:28:04 +0000 (UTC) From: Adrian Chadd <adrian@FreeBSD.org> To: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: svn commit: r225133 - user/adrian/if_ath_tx/sys/dev/ath Message-ID: <201108240728.p7O7S4bO038663@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: adrian Date: Wed Aug 24 07:28:04 2011 New Revision: 225133 URL: http://svn.freebsd.org/changeset/base/225133 Log: The descriptor + link is going to be updated anyway; so there's no need to copy the descriptors into the cloned buffer. Modified: user/adrian/if_ath_tx/sys/dev/ath/if_ath.c Modified: user/adrian/if_ath_tx/sys/dev/ath/if_ath.c ============================================================================== --- user/adrian/if_ath_tx/sys/dev/ath/if_ath.c Wed Aug 24 06:59:59 2011 (r225132) +++ user/adrian/if_ath_tx/sys/dev/ath/if_ath.c Wed Aug 24 07:28:04 2011 (r225133) @@ -1940,14 +1940,9 @@ ath_buf_clone(struct ath_softc *sc, cons /* NOTE: DMA segments will be setup by the setup/chain functions */ - /* - * Copy the descriptor contents - just the active - * number of segments. - */ - memcpy(tbf->bf_desc, bf->bf_desc, - bf->bf_nseg * sizeof(struct ath_desc)); + /* The caller has to re-init the descriptor + links */ - /* Copy status */ + /* Copy state */ memcpy(&tbf->bf_state, &bf->bf_state, sizeof(bf->bf_state)); return tbf;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201108240728.p7O7S4bO038663>