Date: Fri, 5 Feb 2021 17:24:55 +0000 (UTC) From: Justin Hibbits <chmeeedalf@gmail.com> To: Andriy Gapon <avg@FreeBSD.org> Cc: Alfredo Dal'Ava Junior <alfredo@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: Re: git: 6bf9668d9d02 - stable/13 - mrsas: unbreak i386 build Message-ID: <ae8086e7-60d9-45ab-a595-a2c162712d5c@gmail.com> In-Reply-To: <2c848b11-ea07-8107-bf7a-5fa617fe3265@FreeBSD.org> References: <202102051652.115GqYVS049749@gitrepo.freebsd.org> <9f35a234-4c6f-7c86-523f-824dc52656aa@FreeBSD.org> <5066e1e2-e4ce-48c3-8015-74810e7b727c@gmail.com> <2c848b11-ea07-8107-bf7a-5fa617fe3265@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Feb 5, 2021 11:14:34 Andriy Gapon <avg@FreeBSD.org>: > On 05/02/2021 19:12, Justin Hibbits wrote: >> Feb 5, 2021 10:56:13 Andriy Gapon <avg@FreeBSD.org>: >> >>> On 05/02/2021 18:52, Alfredo Dal'Ava Junior wrote: >>>> The branch stable/13 has been updated by alfredo: >>>> >>>> URL: https://cgit.FreeBSD.org/src/commit/?id=3D6bf9668d9d02bdf3e0dafc4= ba1010ef6a9b12247 >>>> >>>> commit 6bf9668d9d02bdf3e0dafc4ba1010ef6a9b12247 >>>> Author:=C2=A0=C2=A0=C2=A0=C2=A0 Alfredo Dal'Ava Junior <alfredo@FreeBS= D.org> >>>> AuthorDate: 2021-02-05 18:43:48 +0000 >>>> Commit:=C2=A0=C2=A0=C2=A0=C2=A0 Alfredo Dal'Ava Junior <alfredo@FreeBS= D.org> >>>> CommitDate: 2021-02-05 19:50:21 +0000 >>>> >>>> =C2=A0=C2=A0=C2=A0 mrsas: unbreak i386 build >>>> =C2=A0=C2=A0=C2=A0 >>>> =C2=A0=C2=A0=C2=A0 Fix build regression introduced by >>>> =C2=A0=C2=A0=C2=A0 e34a057ca6ebdf8e30ec8b0dc21d18eb450bf36a >>>> =C2=A0=C2=A0=C2=A0 >>>> =C2=A0=C2=A0=C2=A0 Reviewed by:=C2=A0=C2=A0=C2=A0 jhibbits >>> Was it?=C2=A0 I do not see an approval in the review request. >> Yes,=C2=A0 it was reviewed by me,=C2=A0 since he took exactly what I sug= gested, and we discussed over IRC. >> > > My apologies then. > I was confused by the fact that you commented in phabricator but accepted= over > IRC (which I didn't know). > > -- > Andriy Gapon Fully understandable,=C2=A0 especially given the timing of the review to co= mmit,=C2=A0 and in relation to the release process going on. - Justin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ae8086e7-60d9-45ab-a595-a2c162712d5c>