Date: Tue, 9 Jul 2024 21:52:59 +0200 From: Piotr Kubaj <pkubaj@anongoth.pl> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 4a72fdf13706 - main - misc/pytorch: fix build on arm64 Message-ID: <Zo2VGwwYDBo5iaKU@KGPE-D16> In-Reply-To: <Zo0SawN5CoA3Hl17@FreeBSD.org> References: <202407091004.469A4q1M005462@gitrepo.freebsd.org> <Zo0SawN5CoA3Hl17@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] No, I just wanted to check whether my pkg-plist patch (which fixes check-plist on powerpc64le) also helps on aarch64 and it turned out aarch64 needed another fix. I don't really use pytorch and recently got too much to work on other things to start upstreaming patches... On 24-07-09 10:35:23, Alexey Dokuchaev wrote: >On Tue, Jul 09, 2024 at 10:04:52AM +0000, Piotr Kubaj wrote: >> commit 4a72fdf137062c477b25bf1602d57745b569a352 >> >> misc/pytorch: fix build on arm64 >> ... >> + # Enable conditional FP16 arithmetic intrinsics >> +-if(CPU_AARCH64 AND LINUX) >> ++if(CPU_AARCH64 AND CMAKE_SYSTEM_NAME MATCHES "FreeBSD") > >Looks like in its current form the patch isn't quite upstreamable. >Did you try to raise this issue with developers to come up with >more generic solution? Ad-hoc patches might fix some problem in >the moment but often become extra burden for ports' maintainers >with future updates. > >./danfe [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQJkBAABCgBOFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmaNlRswFIAAAAAAFQAS cGthLWFkZHJlc3NAZ251cGcub3JncGt1YmFqQGFub25nb3RoLnBsAAoJEHpZm4Ug g5ydUNcP/0EEFyySjjjW6PSy8Kzbdw6/wN8GbhSurIYcXa1Tob58IxPDUQsYky0R BlT+w5tD7//UJ6M1psxYn5x2sVP1b4OXSBiz4rMtbpXhczOiS15ElDUfNW7o7Fk1 c7XHIvx6AOYq2osI2x8KtPUSkEtCvf+RMqfrQk0+cydjIURhVnAXuwcVzv59b2bm h7PXQkRkEbNI0ZRQPXE4GW3IJiZYU02o4xfNLmq9ucXaU2p2XVwuc6xwT8N1qMom A2d1vFNNHZ5MCUpXdZGV/SrbXhTmfVUNfcM/Ze9PAuF+Uqyhmlhr/MpkndiTzhkd S881WeRtZN+6B0PJgp2zk3h7DFMQD6IeOHRe4Ozx28MobdI/2fcBuLNFuAWbJgHE XgIlWIbvwQEp4exZGKs7fFnJKKzq4UUXajcJj0D/F5KaSkYB3BCJ5DIlTCkdrxma WLgzBSoTC2WZ3ZtdpmpySQ8tYaaPmAldPOSJSoZfd0ijHY8FCq1lPxjGADSl50U1 VOcRmYhWHGAN6G1DWr7ZYaE5yZhS+MqhdLEQXvvVa7sMhXq9hKVknMRK+ndmTx86 pE/92qyWEaEejvNqaNheESPhdL4ducevJpyScISz5xOI90rpIk8M0tVrz83yZ+5E TYjpO+ZjglYwYKwyLaAmLNLa0dnrfj5NcGYmA/d5YaisroZAT8/N =J1Yj -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Zo2VGwwYDBo5iaKU>