Date: Wed, 27 Oct 2010 11:12:55 -0700 From: Randi Harper <randi@freebsd.org> To: Devin Teske <dteske@vicor.com> Cc: freebsd-sysinstall@freebsd.org Subject: Re: cpioVerbose=medium broken because cpio(1) no longer accepts -V/--dot Message-ID: <AANLkTinbjO5TOSTkfqbtBeVZm9XDePudxtSCgnHUV78q@mail.gmail.com> In-Reply-To: <1288198564.27442.7.camel@localhost.localdomain> References: <819FEF05-0F22-42E7-9F38-E363A3B2E541@vicor.com> <1288198564.27442.7.camel@localhost.localdomain>
next in thread | previous in thread | raw e-mail | index | archive | help
I have no problem with this patch. Anyone else care to comment? -- randi On Wed, Oct 27, 2010 at 9:56 AM, Devin Teske <dteske@vicor.com> wrote: > Some screenshots of the problem... > > 1. Set cpioVerbose=3Dmedium in the Options editor: > > http://druidbsd.sf.net/images/cpioVerbose_medium_option.png > > 2. Try to perform installation, but error out when unpacking the first > distribution-set (base): > > http://druidbsd.sf.net/images/cpioVerbose_medium_ttyv0_error1.png > > 3. Second error message following the first: > > http://druidbsd.sf.net/images/cpioVerbose_medium_ttyv0_error2.png > > 4. Meanwhile, over on the debug console: > > http://druidbsd.sf.net/images/cpioVerbose_medium_ttyv1_error.png > > > And finally, in tracking down the problem, it appears that FreeBSD-4.x > used gnu-cpio while I see that FreeBSD-8.x is using bsd-cpio. This > explains why `-V'/`--dot' flags have gone missing. > > Writing a PR for this [sysinstall] bug. > -- > Devin > > > > On Tue, 2010-10-26 at 22:03 -0700, Devin Teske wrote: >> Hello fellow sysinstall-hackers, >> >> >> I've been working on some new additions to sysinstall and in >> performing some tests, I came across a rather odd situation. >> >> >> I threw "cpioVerbose=3Dmedium" into our install.cfg file for sysinstall >> (8) and it barfed up an error while trying to unpack the split >> tarballs (blah blah "cpio exited with error status: 1"). >> >> >> Upon closer investigation, it appears that cpio(1) no longer supports >> the "-V" flag which used to print a single "." for each file >> processed. >> >> >> This is rather unfortunate because it now means that we're limited to >> passing "-v" for full verbosity or no "-v" for no output, nothing in- >> between like "-V" or "--dot" from the old FreeBSD-4.11 cpio. >> >> >> Although I'd rather see cpio(1) patched to once-again support a >> medium-verbosity option, I think maybe it's come to the point where we >> take this out of sysinstall. >> >> >> Here's the unified patch of the three files that need patching to >> deprecate the use of `-V' in sysinstall(8) (comments welcome): >> >> >> --- usr.sbin/sysinstall/help/shortcuts.hlp.orig 2007-06-25 >> 09:37:17.000000000 -0700 >> +++ usr.sbin/sysinstall/help/shortcuts.hlp =A0 =A0 =A02010-10-26 >> 15:37:45.000000000 -0700 >> @@ -13,7 +13,7 @@ blanktime =A0 =A0 =A0 =A0 =A0 =A0 =A0 Screen blank tim >> =A0bootManager =A0 =A0 =A0 =A0 =A0 =A0 Select boot manager: booteasy, st= andard or >> none >> =A0browserBinary =A0 =A0 =A0 =A0 =A0 Which doc browser to use (default: = links) >> =A0browserPackage =A0 =A0 =A0 =A0 =A0Which package to get browser from (= default: >> links) >> -cpioVerbose =A0 =A0 =A0 =A0 =A0 =A0 How verbose to be with cpio: high, = medium or >> low >> +cpioVerbose =A0 =A0 =A0 =A0 =A0 =A0 How verbose to be with cpio: high o= r low >> =A0debug =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 Extra debugging? >> =A0defaultrouter =A0 =A0 =A0 =A0 =A0 IP address of default route >> =A0disk =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0Which disk to operate on = (ad0, da0, etc). >> --- usr.sbin/sysinstall/media.c.orig =A0 =A02010-06-13 19:09:06.00000000= 0 >> -0700 >> +++ usr.sbin/sysinstall/media.c 2010-10-26 15:51:06.000000000 -0700 >> @@ -117,8 +117,6 @@ cpioVerbosity() >> >> =A0 =A0 =A0if (cp && !strcmp(cp, "high")) >> =A0 =A0 =A0 =A0 return "-v"; >> - =A0 =A0else if (cp && !strcmp(cp, "medium")) >> - =A0 =A0 =A0 return "-V"; >> =A0 =A0 =A0return ""; >> =A0} >> >> @@ -848,8 +846,6 @@ mediaSetCPIOVerbosity(dialogMenuItem *se >> =A0 =A0 =A0} >> =A0 =A0 =A0else { >> =A0 =A0 =A0 =A0 if (!strcmp(cp, "low")) >> - =A0 =A0 =A0 =A0 =A0 variable_set2(VAR_CPIO_VERBOSITY, "medium", 0); >> - =A0 =A0 =A0 else if (!strcmp(cp, "medium")) >> =A0 =A0 =A0 =A0 =A0 =A0 variable_set2(VAR_CPIO_VERBOSITY, "high", 0); >> =A0 =A0 =A0 =A0 else /* must be "high" - wrap around */ >> =A0 =A0 =A0 =A0 =A0 =A0 variable_set2(VAR_CPIO_VERBOSITY, "low", 0); >> --- usr.sbin/sysinstall/sysinstall.8.orig =A0 =A0 =A0 2010-06-13 >> 19:09:06.000000000 -0700 >> +++ usr.sbin/sysinstall/sysinstall.8 =A0 =A02010-10-26 15:57:21.00000000= 0 >> -0700 >> @@ -749,8 +749,7 @@ >> =A0.Sy Variables : >> =A0.Bl -tag -width indent >> =A0.It cpioVerbose >> -Can be used to set the verbosity of cpio extractions to low, medium >> or >> -high. >> +Can be used to set the verbosity of cpio extractions to low or high. >> =A0.El >> =A0.It mediaGetType >> =A0Interactively get the user to specify some type of media. >> >> >> P.S. It should be noted that cpioVerbose=3Dhigh and cpioVerbose=3Dlow bo= th >> work as expected. >> -- >> Cheers, >> Devin Teske >> >> >> -> CONTACT INFORMATION <- >> Business Solutions Consultant II >> FIS - fisglobal.com >> 510-735-5650 Mobile >> 510-621-2038 Office >> 510-621-2020 Office Fax >> 909-477-4578 Home/Fax >> devin.teske@fisglobal.com >> >> -> LEGAL DISCLAIMER <- >> This message =A0contains confidential =A0and proprietary =A0information >> of the sender, =A0and is intended only for the person(s) to whom it >> is addressed. Any use, distribution, copying or disclosure by any >> other person =A0is strictly prohibited. =A0If you have =A0received this >> message in error, =A0please notify =A0the e-mail sender =A0immediately, >> and delete the original message without making a copy. >> >> -> FUN STUFF <- >> -----BEGIN GEEK CODE BLOCK----- >> Version 3.1 >> GAT/CS d(+) s: a- C++(++++) UB++++$ P++(++++) L++(++++) !E--- W++ N? >> o? K- w O >> M+ V- PS+ PE Y+ PGP- t(+) 5? X+(++) R>++ tv(+) b+(++) DI+(++) D(+) G >> +>++ e>+ h >> r>++ y+ >> ------END GEEK CODE BLOCK------ >> http://www.geekcode.com/ >> >> -> END TRANSMISSION <- > > -- > Cheers, > Devin Teske > > -> CONTACT INFORMATION <- > Business Solutions Consultant II > FIS - fisglobal.com > 510-735-5650 Mobile > 510-621-2038 Office > 510-621-2020 Office Fax > 909-477-4578 Home/Fax > devin.teske@fisglobal.com > > -> LEGAL DISCLAIMER <- > This message =A0contains confidential =A0and proprietary =A0information > of the sender, =A0and is intended only for the person(s) to whom it > is addressed. Any use, distribution, copying or disclosure by any > other person =A0is strictly prohibited. =A0If you have =A0received this > message in error, =A0please notify =A0the e-mail sender =A0immediately, > and delete the original message without making a copy. > > -> FUN STUFF <- > -----BEGIN GEEK CODE BLOCK----- > Version 3.1 > GAT/CS d(+) s: a- C++(++++) UB++++$ P++(++++) L++(++++) !E--- W++ N? o? K= - w O > M+ V- PS+ PE Y+ PGP- t(+) 5? X+(++) R>++ tv(+) b+(++) DI+(++) D(+) G+>++ = e>+ h > r>++ y+ > ------END GEEK CODE BLOCK------ > http://www.geekcode.com/ > > -> END TRANSMISSION <- > > _______________________________________________ > freebsd-sysinstall@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-sysinstall > To unsubscribe, send any mail to "freebsd-sysinstall-unsubscribe@freebsd.= org" >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTinbjO5TOSTkfqbtBeVZm9XDePudxtSCgnHUV78q>