Date: Fri, 4 Oct 2013 16:20:00 GMT From: Jilles Tjoelker <jilles@stack.nl> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/182098: [patch] Change kldxref fts_open ordering so it produces a consistent linker.hints between machines of the same architecture. Message-ID: <201310041620.r94GK0mZ007025@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/182098; it has been noted by GNATS.
From: Jilles Tjoelker <jilles@stack.nl>
To: Derek Schrock <dereks@lifeofadishwasher.com>
Cc: bug-followup@FreeBSD.org
Subject: Re: bin/182098: [patch] Change kldxref fts_open ordering so it
produces a consistent linker.hints between machines of the same
architecture.
Date: Fri, 4 Oct 2013 18:19:21 +0200
On Sat, Sep 28, 2013 at 05:06:00PM -0400, Derek Schrock wrote:
> Looks like I wanted to postpone the last message instead of sending it:
> Ok I see what you mean by using FTS_D. Everything looks good to me, I
> compared the linker.hints generated by the two system from the initial
> description. They're the same.
> However, I slightly modified the testing script from your last comment
> and found three .ko files that don't seem to generate an entry in the
> linker.hints files:
> Patched kldxref:
> $ /usr/src/usr.sbin/kldxref/kldxref -R /boot/
> $ dir="kernel"; strings="$(strings /boot/$dir/linker.hints)"; for f in /boot/"$dir"/*.ko ; do f="${f##*/}"; case "$strings" in *"$f"*) ;; *) echo "what? $f" ;; esac; done
> what? musb.ko
> what? scc.ko
> what? uss820dci.ko
> System kldxref:
> $ kldxref -R /boot/
> $ dir="kernel"; strings="$(strings /boot/$dir/linker.hints)"; for f in /boot/"$dir"/*.ko ; do f="${f##*/}"; case "$strings" in *"$f"*) ;; *) echo "what? $f" ;; esac; done
> what? musb.ko
> what? scc.ko
> what? uss820dci.ko
> Can we assume this isn't a problem with patch since the system kldxref
> doesn't generate a linker.hints with strings that reference those ko
> files?
Yes, this seems not the fault of the patch. It is possible that these
three modules do not actually work.
--
Jilles Tjoelker
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201310041620.r94GK0mZ007025>