Date: Thu, 5 Jun 2003 14:36:20 +1000 From: Tim Robbins <tjr@FreeBSD.ORG> To: Peter Wemm <peter@wemm.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/sed process.c Message-ID: <20030605143620.A86169@dilbert.robbins.dropbear.id.au> In-Reply-To: <20030605032319.49F932A8C1@canning.wemm.org>; from peter@wemm.org on Wed, Jun 04, 2003 at 08:23:19PM -0700 References: <200306041531.h54FVtOD006167@repoman.freebsd.org> <20030605032319.49F932A8C1@canning.wemm.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 04, 2003 at 08:23:19PM -0700, Peter Wemm wrote:
> Tony Finch wrote:
> > fanf 2003/06/04 08:31:55 PDT
> >
> > FreeBSD src repository
> >
> > Modified files:
> > usr.bin/sed process.c
> > Log:
> > Fix substitution when the regex matches the zero-length string.
> > There are two bugs: in the s///g case, the substitution didn't occur
> > at the end of the line; in the s///N case, the code didn't count
> > forwards along the line properly. See the sg, s3, s4, and s5 tests
> > in src/tools/regression/usr.bin/sed/.
> >
> > Reviewed by: tjr
>
> OH MY GOD, YOU KILLED KENNY^H^H^H^H^HSED!!!!
[...]
> Backing out this change to process.c "fixed" it.
Try this.
Change 32608 by tjr@tjr_dev on 2003/06/04 20:39:50
Restore old logic to avoid putting null bytes into the output.
Affected files ...
... //depot/user/tjr/freebsd-tjr/src/usr.bin/sed/process.c#3 edit
Differences ...
==== //depot/user/tjr/freebsd-tjr/src/usr.bin/sed/process.c#3 (text+ko) ====
363a364,366
> } else if (match[0].rm_so == slen) {
> s += match[0].rm_so;
> slen = -1;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030605143620.A86169>