Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 25 Oct 2018 14:35:53 +0000 (UTC)
From:      Hans Petter Selasky <hselasky@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   svn commit: r339715 - stable/10/sys/dev/sound/midi
Message-ID:  <201810251435.w9PEZrXc047429@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: hselasky
Date: Thu Oct 25 14:35:52 2018
New Revision: 339715
URL: https://svnweb.freebsd.org/changeset/base/339715

Log:
  MFC r339581:
  Fix off-by-one which can lead to panics.
  
  Found by:		Peter Holm <peter@holm.cc>
  Sponsored by:		Mellanox Technologies

Modified:
  stable/10/sys/dev/sound/midi/sequencer.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/dev/sound/midi/sequencer.c
==============================================================================
--- stable/10/sys/dev/sound/midi/sequencer.c	Thu Oct 25 14:34:38 2018	(r339714)
+++ stable/10/sys/dev/sound/midi/sequencer.c	Thu Oct 25 14:35:52 2018	(r339715)
@@ -737,7 +737,7 @@ static int
 seq_fetch_mid(struct seq_softc *scp, int unit, kobj_t *md)
 {
 
-	if (unit > scp->midi_number || unit < 0)
+	if (unit >= scp->midi_number || unit < 0)
 		return EINVAL;
 
 	*md = scp->midis[unit];



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201810251435.w9PEZrXc047429>