Date: Thu, 26 Jul 2018 00:16:32 -0700 From: Yuri <yuri@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r475335 - head/devel/liteide Message-ID: <faa15cf5-fb73-3665-4f17-f63ca0f92502@freebsd.org> In-Reply-To: <20180726070858.GA93790@FreeBSD.org> References: <201807252025.w6PKPsxQ097871@repo.freebsd.org> <20180726064408.GC77261@FreeBSD.org> <32e60b17-116f-e431-872b-903412e4abd1@freebsd.org> <20180726070858.GA93790@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7/26/18 12:08 AM, Alexey Dokuchaev wrote:
> Yes, I know, but as long as you never check against the default FLAVOR,
> you don't need it.
>
>>> Because qt5 is default flavor, and you're checking for qt4 first (qt5 is
>>> in .else branch) and never for .if ${FLAVOR} == qt5.
>> Framework checks that flavor is in the list. Here, when flavor isn't
>> qt4, it is safe to assume that it is qt5.
> Thank you captain. Not sure why you had to explain this, but that does
> not change the point that you don't need FLAVOR?=${FLAVORS:[1]}. :U
> will protect you from undefined variable, and it would be defined in the
> Qt4 case because it's not the default flavor.
I think it's conceptually simpler to have this line, so that FLAVOR is
always defined after it.
This line increases readability and understandability, IMO.
Yuri
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?faa15cf5-fb73-3665-4f17-f63ca0f92502>