Date: Tue, 15 Sep 2015 01:34:21 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Aleksandr Rybalko <ray@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: Re: svn commit: r287782 - stable/10/sys/dev/vt Message-ID: <20150915013421.GA59565@FreeBSD.org> In-Reply-To: <201509141442.t8EEg7ao012596@repo.freebsd.org> References: <201509141442.t8EEg7ao012596@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Sep 14, 2015 at 02:42:07PM +0000, Aleksandr Rybalko wrote: > New Revision: 287782 > URL: https://svnweb.freebsd.org/changeset/base/287782 > > Log: > MFC: r272715 > Allow vt(4) to disable terminal bell with > `sysctl kern.vt.bell_enable=0`, similar as syscons(4) do. > [...] > +VT_SYSCTL_INT(enable_bell, 1, "Enable bell"); I think you've meant `sysctl kern.vt.enable_bell=0' in the commit log. > + if (!vt_enable_bell) > + return; > + > if (vd->vd_flags & VDF_QUIET_BELL) > return; Hm, I'm wondering why having another sysctl is required when there's already a way to shut the bell up with VDF_QUIET_BELL flag? Also, there's certain naming inconsistency between syscons(4) and vt(4). On my stable/8 laptop, I see this: $ sysctl -d hw.syscons.bell hw.syscons.bell: enable bell On my -CURRENT desktop, this: $ sysctl -d kern.vt.enable_bell kern.vt.enable_bell: Enable bell ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150915013421.GA59565>