Date: Thu, 9 May 2019 10:27:09 -0700 From: "Enji Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Kyle Evans <kevans@FreeBSD.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head@freebsd.org Subject: Re: svn commit: r347392 - head/sbin/ifconfig Message-ID: <C6C548A7-4E14-4B23-B348-879CF1082714@gmail.com> In-Reply-To: <201905091258.x49CwYr0095200@repo.freebsd.org> References: <201905091258.x49CwYr0095200@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On May 9, 2019, at 05:58, Kyle Evans <kevans@FreeBSD.org> wrote: > > Author: kevans > Date: Thu May 9 12:58:33 2019 > New Revision: 347392 > URL: https://svnweb.freebsd.org/changeset/base/347392 > > Log: > ifconfig(8): Partial revert of r347241 > > r347241 introduced an ifname <-> kld mapping table, mostly so tun/tap/vmnet > can autoload the correct module on use. It also inadvertently made bogus > some previously valid uses of sizeof(). > > Revert back to ifkind on the stack for simplicity sake. This reduces the > diff from the previous version of ifmaybeload for easiser auditing. Hi Kyle, Thank you for this revert. This change fixed the FreeBSD test suite runs, which are once again green after this change. A number of tests which use ifconfig were failing because they couldn’t configure interfaces: https://ci.freebsd.org/job/FreeBSD-head-amd64-test/11134/testReport/ . Cheers! -Enji
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C6C548A7-4E14-4B23-B348-879CF1082714>