Date: Wed, 01 Apr 2015 02:24:20 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Don Lewis <truckman@FreeBSD.org> Cc: ports@FreeBSD.org Subject: Re: github tags containing "/" Message-ID: <551B9D24.5060200@FreeBSD.org> In-Reply-To: <201504010713.t317DJCX002188@gw.catspoiler.org> References: <201504010713.t317DJCX002188@gw.catspoiler.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--n0VTrIOXOhKGgsLFVxeOj5RhEAigmHR0X
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
On 4/1/2015 2:13 AM, Don Lewis wrote:
> On 1 Apr, Bryan Drewery wrote:
>> On 4/1/2015 1:54 AM, Don Lewis wrote:
>>> I'm working on a couple of new ports where I'm using fetching the
>>> distfiles from github. One quirk is that the tags start with a prefi=
x
>>> of "tags/v". I'm setting PKGNAMEPREFIX=3D${PYTHON_PKGNAMEPREFIX}.
Wow it really has 'tags/' in the tags and 'branches/' in the branches.
It has to be a bad conversion from SVN. Anyway it is intended to be
supported fine...
>>>
>>> If I follow the example for in the Porters Handbook using
>>> DISTVERSIONPREFIX=3Dtags/v then the distfile gets named
>>> ${PORTNAME}-tags/v${PORTVERSION}_GH0.tar.gz,
>>> which seems somewhat undesirable. This seems to be a bit misleading
>>> and risky because this port is just a python wrapper around another
>>> library that also has the same PORTNAME. That port hasn't been
>>> converted to fetch from github, and when it does it seems like there
>>> would be a chance of collisions.
>>>
>>> I seem to get better results by setting GH_TAGNAME=3Dtags/v${PORTVERS=
ION}.
>>> In that case, the distfile gets named
>>> ${GH_ACCOUNT}-${GH_PROJECT}-${PORTVERSION}-tags-v${PORTVERSION}_GH0.t=
ar.gz.
>>> This seems to be excessively verbose, but safer.
Just use GH_TAGNAME=3Dtags/v${PORTVERSION} for now.
The DISTVERSIONPREFIX is supposed to work in this case as well. I'll
look into it tomorrow.
It is likely the same as
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D199069 which I
realized earlier today.
The DISTNAME you see is intentionally verbose so it is unique and avoids
rerolled checksums on account/project renames or PORTVERSION changes or
github-specific rerolls. It is intended to stand out as a
GITHUB-generated file so it is not confused with other distributed files.=
The DISTVERSIONPREFIX _not_ producing the same filename is a bug.
--=20
Regards,
Bryan Drewery
--n0VTrIOXOhKGgsLFVxeOj5RhEAigmHR0X
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBAgAGBQJVG50kAAoJEDXXcbtuRpfPxeAH/RyiwwIg6TJQOshd2NYLaqoE
rxgpmitaEwFjCrNFmecZ1vXCwWfOQtWZcx9LFZabQnXCwEUGaV2P52UbusA5YDav
fs5c9KH3I+WdJHAyU/mNW0RR4HeTW4ZEUspejyHrlf9Gmf1TZRn6YIwiJGmkFqjY
r0BtoyHsgq5HvEuUO9kfVH2sW3MOWnVHBK+TiIh23lLCl9qgyHleM4jl6M613WAq
l30SZbjP0BINUsQkKXTgLcElJ/POSKSln0etGwG6mh5DyWs0/j++RIBVXP02FJIN
aLAP5fRtIrOVxm2hsAz/piHtJaFkw/GVINEAYu8JlayHRpqpQ3sovxusgaiePp4=
=23ja
-----END PGP SIGNATURE-----
--n0VTrIOXOhKGgsLFVxeOj5RhEAigmHR0X--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?551B9D24.5060200>