Date: Thu, 26 Oct 2023 11:52:06 -0700 From: Enji Cooper <yaneurabeya@gmail.com> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: Dimitry Andric <dim@freebsd.org>, markj@freebsd.org, "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: 6120673f7566 - main - tests: fix ATF_TESTS_PYTEST no clean build Message-ID: <8962DE73-16C0-4DF0-87B9-53A5ECC3D158@gmail.com> In-Reply-To: <ZTWee21v37lQ6oMj@FreeBSD.org> References: <202310201747.39KHlUgB005433@gitrepo.freebsd.org> <ACCB40BA-AFD0-4836-8FC3-F9BC70CC878A@FreeBSD.org> <ZTWee21v37lQ6oMj@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
> On Oct 22, 2023, at 3:13 PM, Gleb Smirnoff <glebius@FreeBSD.org> wrote:
>
> On Sat, Oct 21, 2023 at 09:07:26PM +0200, Dimitry Andric wrote:
> D> > commit 6120673f7566c35023921540d2d682572d1bf1ce
> D> > Author: Gleb Smirnoff <glebius@FreeBSD.org>
> D> > AuthorDate: 2023-10-20 17:47:08 +0000
> D> > Commit: Gleb Smirnoff <glebius@FreeBSD.org>
> D> > CommitDate: 2023-10-20 17:47:08 +0000
> D> >
> D> > tests: fix ATF_TESTS_PYTEST no clean build
> D> >
> D> > The hack with .xtmp file was effectively making the make to
> D> > ignore changes to the sources, breaking NO_CLEAN builds. The
> D> > hack can be actually omitted as setting SCRIPTSNAME_${_T} for
> D> > every test is sufficient to prevent renaming by bsd.prog.mk.
> D> >
> D> > Reviewed by: melifaro
> D> > Differential Revision: https://reviews.freebsd.org/D42283
> D>
> D> This appears to break clean builds, in that it now deletes files
> D> mentioned in ATF_TESTS_PYTEST in the _source_ directories, leaving your
> D> git checkout looking as follows:
>
> Oh shit... Sorry. :( When I come up with a better change, who would
> be a good reviewer for the change?
Hi Gleb!
If you include the tests group, we might be able to help (it’s a bit larger than asomers@/jmmv@). jmmv@FreeBSD.org has been inactive these days too — it would probably be a good idea to mark his account disabled (if possible). bdrewery@ might have been a good resource as well.
Cheers,
-Enji
PS I’m swamped with work/life stuff, but I try to give my input if/when I can.
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEtvtxN6kOllEF3nmX5JFNMZeDGN4FAmU6tVYACgkQ5JFNMZeD
GN7vYg/9Ha/8FGf0PpdQ8kPee2iSn/00L6D9cfs9nZT92JhqNl817+7KAVPhRXdG
SdV7jatFIlFRzUMXHgdCi1A7j1desfdCthNmX9RM3rTZ16KfG+U9Mg7FrWvTIXFz
pa3gunbUXJbF8y+ZfK73ziabqQqkMfyWB3UkdMaSgNcpjF9CKxLxsgZrpjiRJAf0
hEmPF0R+eFxRn+fewmYpG1Fz5b8lPAU6GgqofRVcZIMbwdM1U7GnEJsL2ekhSEI0
2b53Y4BUXrDkwHr5x2MrpQdlacQKQtE3klwxJkS42Fxbi82mOp3sujXfklQ3qtAh
69GV6ywH56wj49a6ezdnMFOxUdLzapdClFO/ye5e5fa6nlJDFWshAwT4U/V+RL7/
pNvzuAhdHZKTfLZg1SFhcszHXjUB6bJyd4CQtOQd+iygWhAXYMjuTsmulBtph5+g
CNmJN7/L1OMzlmChkeQAqj5j+rBzAI6Al6Sh7tDL4p1rtKAxTmQNwUfFa7POl0KB
NI3ecIBdCAwhvDu1iCZRr/hvsLynkXyEc2gmzx0E7K9pggXwi5hlRXa52W27TSl+
ovkt156xxJWygGIPX46Kgf1aD8OYWnz/ZKH2nD534OVVcNY6oIP5wqDWIRGNjetU
8DR9Jyzes33mkmA09VSsZUisi4hTBS9qNr3ENbsjAUYRr39uxUs=
=FD7x
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8962DE73-16C0-4DF0-87B9-53A5ECC3D158>