Date: Mon, 2 Nov 2015 09:08:45 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: NGie Cooper <yaneurabeya@gmail.com> Cc: src-committers <src-committers@freebsd.org>, svn-src-projects@freebsd.org Subject: Re: svn commit: r290263 - projects/collation/contrib/netbsd-tests/lib/libc/locale Message-ID: <20151102080844.GA19972@ivaldir.etoilebsd.net> In-Reply-To: <2B614865-4775-4DF2-8EF7-D820E114F811@gmail.com> References: <201511020759.tA27xHLU027275@repo.freebsd.org> <2B614865-4775-4DF2-8EF7-D820E114F811@gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Mon, Nov 02, 2015 at 12:05:04AM -0800, NGie Cooper wrote: > > > On Nov 1, 2015, at 23:59, Baptiste Daroussin <bapt@FreeBSD.org> wrote: > > > > Author: bapt > > Date: Mon Nov 2 07:59:17 2015 > > New Revision: 290263 > > URL: https://svnweb.freebsd.org/changeset/base/290263 > > > > Log: > > Fix regression test on multibytes > > > > 0x07FF and 0x0800 are valid multibyte characters: > > 'DOUBLE QUESTION MARK' and 'QUESTION EXCLAMATION MARK' > > > > Modified: > > projects/collation/contrib/netbsd-tests/lib/libc/locale/t_mbstowcs.c > > > > Modified: projects/collation/contrib/netbsd-tests/lib/libc/locale/t_mbstowcs.c > > ============================================================================== > > --- projects/collation/contrib/netbsd-tests/lib/libc/locale/t_mbstowcs.c Mon Nov 2 07:46:47 2015 (r290262) > > +++ projects/collation/contrib/netbsd-tests/lib/libc/locale/t_mbstowcs.c Mon Nov 2 07:59:17 2015 (r290263) > > @@ -87,7 +87,7 @@ static struct test { > > 0x5B, 0x01, 0x7F, 0x5D, 0x5B, 0x80, 0x07FF, 0x5D, 0x5B, 0x0800, > > 0xFFFF, 0x5D, 0x5B, 0x10000, 0x10FFFF, 0x5D, 0x0A > > }, > > - { 1, -1, -1, 1, 1, -1, -1, 1, 1, -1, -1, 1, 1, -1, -1, > > + { 1, -1, -1, 1, 1, -1, 1, 1, 1, 1, -1, 1, 1, -1, -1, > > 1, 1, -1, -1, 1, 1, -1, -1, 1, -1 > > Please file an upstream PR for this (and any other failures you find) and if possible CC me. > Sure I can do that > I’ve been adding... > > #ifdef __FreeBSD__ > /* FreeBSD-specific fix */ > #else > /* Old code from NetBSD */ > #endif > I can do that if you prefer > … to track what needs to be upstreamed. There is another one needed, but this time I think the regression test is right, I'll dig a bit more. Best regards, Bapt [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlY3GgwACgkQ8kTtMUmk6Ez7aACfanrL8PZ6N0qoqdaQVbIrc7KY hkQAoLm7yxaOLghGGqgVbT9Jgn7JdJSh =Ejfe -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151102080844.GA19972>