Date: Sat, 15 Dec 2001 16:58:32 -0500 From: Mike Barcroft <mike@FreeBSD.org> To: Luigi Rizzo <luigi@FreeBSD.org> Cc: Kris Kennaway <kris@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/rm rm.c src/usr.sbin/chown chown.c src/usr.sbin/dev_mkdb dev_mkdb.c Message-ID: <20011215165832.A77929@espresso.q9media.com> In-Reply-To: <20011215095930.A62613@iguana.aciri.org>; from luigi@FreeBSD.org on Sat, Dec 15, 2001 at 09:59:30AM -0800 References: <200112141622.fBEGMg705939@freefall.freebsd.org> <20011215090750.A91194@citusc17.usc.edu> <20011215095930.A62613@iguana.aciri.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Luigi Rizzo <luigi@FreeBSD.org> writes: > There is something I do not follow. > > Over time we have gone through great pains to keep the code compatible > with a wide range of compilers (including K&R when possible, by > using __P() macros), and now people complain suggesting that instead > of supplying perfectly legal (K&R and ANSI) C prototypes to 3 > functions, which do not break anything and only increase code > portability towards possibly broken compilers, I should instead > compile the source tree with a version-specific compiler. > > Am i the only one who sees a contraddiction here ? Correct code should not be modified to cope with compiler bugs. In this case, your compiler is incorrectly requiring a prototype for main() in order to silence a diagnostic. This change should be backed out. Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011215165832.A77929>