Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 4 Jan 2021 12:58:58 -0800 (PST)
From:      "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net>
To:        Emmanuel Vadot <manu@bidouilliste.com>
Cc:        rgrimes@freebsd.org, "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net>, Emmanuel Vadot <manu@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: 2d486ba15f33 - main - pkgbase: Move bectl to the runtime package
Message-ID:  <202101042058.104Kwwhx004966@gndrsh.dnsmgr.net>
In-Reply-To: <20210104215208.d02e08a9ef9fdd0387287784@bidouilliste.com>

next in thread | previous in thread | raw e-mail | index | archive | help
> On Mon, 4 Jan 2021 12:49:19 -0800 (PST)
> "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> wrote:
> 
> > > The branch main has been updated by manu:
> > > 
> > > URL: https://cgit.FreeBSD.org/src/commit/?id=2d486ba15f3367072d631ee588192ef46687fa4b
> > > 
> > > commit 2d486ba15f3367072d631ee588192ef46687fa4b
> > > Author:     Emmanuel Vadot <manu@freebsd.org>
> > > AuthorDate: 2020-12-21 15:00:02 +0000
> > > Commit:     Emmanuel Vadot <manu@FreeBSD.org>
> > > CommitDate: 2021-01-04 15:17:12 +0000
> > > 
> > >     pkgbase: Move bectl to the runtime package
> > >     
> > >     runtime contain what is needed to boot in single user and repair a
> > >     system, bectl could be handy to have in this situation.
> > 
> > I would think it belongs in the zfs package,
> > as unless you have zfs you do not need bectrl.
> 
>  There is no zfs package.

I would consider that an oversight.

>  Having zfs is controlled by WITH/WITHOUT_ZFS and this is not related
> to pkgbase.

WITH/WITHOUT are compile time constructs, pkgbase is an install time
set of tools, why can there not be a zfs pkg?  

> > 
> > >     
> > >     Differential Revision:  https://reviews.freebsd.org/D27708
> > > ---
> > >  lib/libbe/Makefile  | 1 +
> > >  sbin/bectl/Makefile | 1 +
> > >  2 files changed, 2 insertions(+)
> > > 
> > > diff --git a/lib/libbe/Makefile b/lib/libbe/Makefile
> > > index 291e2438ee2a..d1fab41578bf 100644
> > > --- a/lib/libbe/Makefile
> > > +++ b/lib/libbe/Makefile
> > > @@ -4,6 +4,7 @@ SHLIBDIR?=	/lib
> > >  
> > >  .include <src.opts.mk>
> > >  
> > > +PACKAGE=	runtime
> > >  LIB=		be
> > >  SHLIB_MAJOR=	1
> > >  SHLIB_MINOR=	0
> > > diff --git a/sbin/bectl/Makefile b/sbin/bectl/Makefile
> > > index 6fa84f48661d..46d43306b9ca 100644
> > > --- a/sbin/bectl/Makefile
> > > +++ b/sbin/bectl/Makefile
> > > @@ -2,6 +2,7 @@
> > >  
> > >  .include <src.opts.mk>
> > >  
> > > +PACKAGE=runtime
> > >  PROG=	bectl
> > >  MAN=	bectl.8
> > >  
> > > 
> > 
> > -- 
> > Rod Grimes                                                 rgrimes@freebsd.org
> 
> 
> -- 
> Emmanuel Vadot <manu@bidouilliste.com>
> 

-- 
Rod Grimes                                                 rgrimes@freebsd.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202101042058.104Kwwhx004966>