Date: Tue, 20 Mar 2012 15:20:41 +0000 From: David Chisnall <theraven@theravensnest.org> To: "Pedro F. Giffuni" <pfg@FreeBSD.org> Cc: svn-src-stable@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, svn-src-stable-9@FreeBSD.org Subject: Re: svn commit: r229551 - in stable/9/contrib/libstdc++: . config/os/aix include/bits include/ext include/tr1 libsupc++ src Message-ID: <0272CDA5-A574-436D-8FCA-6E9427924D6F@theravensnest.org> In-Reply-To: <201201050148.q051mQl5008914@svn.freebsd.org> References: <201201050148.q051mQl5008914@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This part of the change gratuitously alters the vtable layout of a core =
ABI class and will break things. Please revert it.
David
On 5 Jan 2012, at 01:48, Pedro F. Giffuni wrote:
> Modified: stable/9/contrib/libstdc++/libsupc++/typeinfo
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> --- stable/9/contrib/libstdc++/libsupc++/typeinfo Thu Jan 5 =
01:40:42 2012 (r229550)
> +++ stable/9/contrib/libstdc++/libsupc++/typeinfo Thu Jan 5 =
01:48:25 2012 (r229551)
> @@ -99,7 +99,13 @@ namespace std=20
> #endif
> bool operator!=3D(const type_info& __arg) const
> { return !operator=3D=3D(__arg); }
> - =20
> +
> + // Return true if this is a pointer type of some kind
> + virtual bool __is_pointer_p() const;
> +
> + // Return true if this is a function type
> + virtual bool __is_function_p() const;
> +
> // Try and catch a thrown type. Store an adjusted pointer to the
> // caught type in THR_OBJ. If THR_TYPE is not a pointer type, then
> // THR_OBJ points to the thrown object. If THR_TYPE is a pointer
> @@ -113,12 +119,6 @@ namespace std=20
> virtual bool __do_upcast(const __cxxabiv1::__class_type_info =
*__target,
> void **__obj_ptr) const;
>=20
> - // Return true if this is a pointer type of some kind
> - virtual bool __is_pointer_p() const;
> -
> - // Return true if this is a function type
> - virtual bool __is_function_p() const;
> -
> protected:
> const char *__name;
>=20
>=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0272CDA5-A574-436D-8FCA-6E9427924D6F>