Date: Sat, 9 Dec 2006 01:01:46 +0800 (CST) From: Rong-En Fan <rafan@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Cc: kde@FreeBSD.org Subject: ports/106486: [PATCH] pass correct QTDIR/KDEDIR in bsd.kde.mk Message-ID: <200612081701.kB8H1kFr090245@svm.csie.ntu.edu.tw> Resent-Message-ID: <200612081710.kB8HAHqu002836@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 106486 >Category: ports >Synopsis: [PATCH] pass correct QTDIR/KDEDIR in bsd.kde.mk >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri Dec 08 17:10:17 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Rong-En Fan >Release: FreeBSD 6.2-PRERELEASE amd64 >Organization: NTU CSIE >Environment: >Description: QTDIR/KDEDIR is not passwd when USE_QT_VER != CVS. When X11BASE sets to a non-standard, say /usr/X11R6, value, some ports fail to build: devel/libchipcard-kde graphics/djvulibre graphics/gephex irc/kvirc net-p2p/dctc-gui-qt I fixed some of them by passing QTDIR. However, fixing this in bsd.kde.mk is much better. Moreover, we can clean up some ports that manually set QTDIR. I tested this patch with the five ports mentioned above in tinderbox. All build fine. >How-To-Repeat: >Fix: Index: bsd.kde.mk =================================================================== RCS file: /home/pcvs/ports/Mk/bsd.kde.mk,v retrieving revision 1.63 diff -u -r1.63 bsd.kde.mk --- bsd.kde.mk 12 Sep 2006 23:26:10 -0000 1.63 +++ bsd.kde.mk 8 Dec 2006 16:47:49 -0000 @@ -125,7 +125,8 @@ --with-qt-libraries=${QT_PREFIX}/lib \ --with-extra-libs=${LOCALBASE}/lib \ --with-extra-includes=${LOCALBASE}/include -CONFIGURE_ENV+= MOC="${MOC}" CPPFLAGS="${CPPFLAGS} ${QTCPPFLAGS}" LIBS="${QTCFGLIBS}" +CONFIGURE_ENV+= MOC="${MOC}" CPPFLAGS="${CPPFLAGS} ${QTCPPFLAGS}" LIBS="${QTCFGLIBS}" \ + QTDIR="${QT_PREFIX}" KDEDIR="${KDE_PREFIX}" .endif # !defined(QT_NONSTANDARD) .else IGNORE= cannot install: unsupported value of USE_QT_VER >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200612081701.kB8H1kFr090245>