Date: Fri, 10 Feb 2017 12:19:35 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r313564 - head/sys/kern Message-ID: <E88B0F6E-D38C-4B08-B961-1D5E7BFE3742@gmail.com> In-Reply-To: <2023305.EdEEquGYxm@ralph.baldwin.cx> References: <201702101925.v1AJPqhR022902@repo.freebsd.org> <2023305.EdEEquGYxm@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Feb 10, 2017, at 11:38, John Baldwin <jhb@freebsd.org> wrote: > > On Friday, February 10, 2017 07:25:52 PM John Baldwin wrote: >> Author: jhb >> Date: Fri Feb 10 19:25:52 2017 >> New Revision: 313564 >> URL: https://svnweb.freebsd.org/changeset/base/313564 >> >> Log: >> Drop the "created from" line from files generated by makesyscalls.sh. >> >> This information is less useful when the generated files are included in >> source control along with the source. If needed it can be reconstructed >> from the $FreeBSD$ tag in the generated file. Removing this information >> from the generated output permits committing the generated files along >> with the change to the system call master list without having inconsistent >> metadata in the generated files. > > There is a tradeoff of course. Having the generated files mixed in the > commits does make the diff more noisy, and it can be more of a pain in reviews. > One can still just not include the generated files when posting reviews (we > already have to do that because you have to generate the files to do testing). > > However, I do think that at least for MFCs we should include the generated > files in the merge so that on stable branches we don't have known-broken > commits once this change is merged back to stable branches. Uhh…. $FreeBSD$ isn’t being expanded in some of these files… $ svn pg svn:keywords sys/sys/syscall.mk FreeBSD=%H $ grep '$FreeBSD' sys/sys/syscall.mk # $FreeBSD$ -Ngie [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYniBYAAoJEPWDqSZpMIYVqLYQAMB/6hAbu9FVU/fLJgicXo6m QcartWGIky1OdN/7swg3pA9nSQZGsRnN+HZtxxYIx7aHfFwREQA3yKRSeO4Fz8mk AU+yJC/1BJtONBXse3iaVG9jZRYMYdMCaWF9r5beaZ1IOuQ0VTXj0Njlq/YibYl7 Yp3Yd+WglQXeYVHNWM8+uxA2nvEwKjeujakEcrqtCXf3z5PIL/M4tvPyJxzigS9m qhNMgtJGbur0dQ/k7RK+CIeB2Djt5sa5m68RNo4UiLoKk2t896sN8Vo+B67bkKLQ DU8E7CBJceOFVOrvZT35MWXt/F+c6jRMmWRebxtKRRA2qGJaVOyXEbO7+ay3LJq0 Ovb0AUDJTMZuULp7E25aD14kZLfxSfzuMGnLafPO/CxQLgfO2L2EZoqUtmVhKtEA AI56bQmvIgmAHWjCJuXs1LGY7QHwT8hbgibbmTIHqhN+m+KrxqSfce2Fz0jcaLwK n7lFTe7Z2zFB6p7TMhHo69BlHYRWLZZp6zEYxWKGSClXqVRAfiCVJTr6qquvTf+6 zZW/aXYBX5g7Uo1xU3x05+48bqoCNF8Wmk+Cq7M/+usvcmK5NjiudDndMgDrJ1C3 GgwMFWk8hIuYLrBug74FLCEqaAYyhJiJ6BOjUhmquPQVWeHSV1N5pRX/josRWRq/ FupAO/5eRHZiKTWlnd/5 =5tI3 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E88B0F6E-D38C-4B08-B961-1D5E7BFE3742>