Date: Mon, 24 Dec 2007 15:19:06 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: Bruce Evans <brde@optusnet.com.au> Cc: Mark Fullmer <maf@splintered.net>, freebsd-stable@freebsd.org, "Freebsd-Net@Freebsd. Org" <freebsd-net@freebsd.org> Subject: Re: Packet loss every 30.999 seconds Message-ID: <20071224131906.GB57756@deviant.kiev.zoral.com.ua> In-Reply-To: <20071223095314.G1323@delplex.bde.org> References: <20071221234347.GS25053@tnn.dglawrence.com> <MDEHLPKNGKAHNMBLJOLKMEKLJAAC.davids@webmaster.com> <20071222050743.GP57756@deviant.kiev.zoral.com.ua> <20071223032944.G48303@delplex.bde.org> <20071222201613.GX57756@deviant.kiev.zoral.com.ua> <20071223095314.G1323@delplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--nuX4E7Vid9I2gnPU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sun, Dec 23, 2007 at 10:20:31AM +1100, Bruce Evans wrote:
> On Sat, 22 Dec 2007, Kostik Belousov wrote:
> >Ok, since you talked about this first :). I already made the following
> >patch, but did not published it since I still did not inspected all
> >callers of MNT_VNODE_FOREACH() for safety of dropping mount interlock.
> >It shall be safe, but better to check. Also, I postponed the check
> >until it was reported that yielding does solve the original problem.
>=20
> Good. I'd still like to unobfuscate the function call.
What do you mean there ?=20
> Putting the count in the union seems fragile at best. Even if nothing
> can access the marker vnode, you need to context-switch its old contents
> while using it for the count, in case its old contents is used. Vnode-
> printing routines might still be confused.
Could you, please, describe what you mean by "contex-switch" for the
VMARKER ?
Mark, could you, please, retest the patch below in your setup ?
I want to put a change or some edition of it into the 7.0 release, and
we need to move fast to do this.
diff --git a/sys/kern/vfs_mount.c b/sys/kern/vfs_mount.c
index 14acc5b..046af82 100644
--- a/sys/kern/vfs_mount.c
+++ b/sys/kern/vfs_mount.c
@@ -1994,6 +1994,12 @@ __mnt_vnode_next(struct vnode **mvp, struct mount *m=
p)
mtx_assert(MNT_MTX(mp), MA_OWNED);
=20
KASSERT((*mvp)->v_mount =3D=3D mp, ("marker vnode mount list mismatch"));
+ if ((*mvp)->v_yield++ =3D=3D 500) {
+ MNT_IUNLOCK(mp);
+ (*mvp)->v_yield =3D 0;
+ uio_yield();
+ MNT_ILOCK(mp);
+ }
vp =3D TAILQ_NEXT(*mvp, v_nmntvnodes);
while (vp !=3D NULL && vp->v_type =3D=3D VMARKER)
vp =3D TAILQ_NEXT(vp, v_nmntvnodes);
diff --git a/sys/sys/vnode.h b/sys/sys/vnode.h
index dc70417..6e3119b 100644
--- a/sys/sys/vnode.h
+++ b/sys/sys/vnode.h
@@ -131,6 +131,7 @@ struct vnode {
struct socket *vu_socket; /* v unix domain net (VSOCK) */
struct cdev *vu_cdev; /* v device (VCHR, VBLK) */
struct fifoinfo *vu_fifoinfo; /* v fifo (VFIFO) */
+ int vu_yield; /* yield count (VMARKER) */
} v_un;
=20
/*
@@ -185,6 +186,7 @@ struct vnode {
#define v_socket v_un.vu_socket
#define v_rdev v_un.vu_cdev
#define v_fifoinfo v_un.vu_fifoinfo
+#define v_yield v_un.vu_yield
=20
/* XXX: These are temporary to avoid a source sweep at this time */
#define v_object v_bufobj.bo_object
--nuX4E7Vid9I2gnPU
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (FreeBSD)
iD8DBQFHb7HJC3+MBN1Mb4gRAjM7AJ9DxpeIkxYG5g3BxgVpfoRsYGgVYgCgwfu+
pWV14zgIp7rRQRHlldbdOw4=
=Ej13
-----END PGP SIGNATURE-----
--nuX4E7Vid9I2gnPU--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071224131906.GB57756>