Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 13 Mar 2010 13:56:57 +0000
From:      Bruce Simpson <bms@incunabulum.net>
To:        "Robert N. M. Watson" <rwatson@FreeBSD.org>
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Randall Stewart <rrs@lakerest.net>
Subject:   Re: svn commit: r205104 - in head/sys: dev/xen/netback netinet netinet6
Message-ID:  <4B9B99A9.7040904@incunabulum.net>
In-Reply-To: <92C0A9B0-9297-4F56-A6A1-603006423230@FreeBSD.org>
References:  <201003122258.o2CMwqDM039077@svn.freebsd.org> <alpine.BSF.2.00.1003131257060.51476@fledge.watson.org> <2F4A2F84-4955-49C2-B25E-BB987BC27815@lakerest.net> <92C0A9B0-9297-4F56-A6A1-603006423230@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 03/13/10 13:53, Robert N. M. Watson wrote:
> On Mar 13, 2010, at 1:50 PM, Randall Stewart wrote:
>    
>> I could refactor that this way if you want... it would mean a few more de-ref's and
>> looking to see if its a v4 or v6 packet and then doing the proper offset...
>>      

This is the sort of thing which M_PROTO* flags are good for.

Derefs in the hot path should be amortized whenever that makes sense.




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B9B99A9.7040904>