Date: Sun, 15 May 2011 19:27:17 +0400 From: "Andrey V. Elsukov" <ae@FreeBSD.org> To: Marcel Moolenaar <marcel@xcllnt.net> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r221952 - head/sbin/geom/class/part Message-ID: <4DCFF0D5.3080309@FreeBSD.org> In-Reply-To: <7B2294F7-8383-42F2-8127-759DBCD3540A@xcllnt.net> References: <201105151145.p4FBjDVR038539@svn.freebsd.org> <7B2294F7-8383-42F2-8127-759DBCD3540A@xcllnt.net>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 15.05.2011 19:09, Marcel Moolenaar wrote: >> Simplify the code a bit. For own providers GEOM_PART always provides >> "start" and "end" config attributes. >> >> MFC after: 1 week > > Just to make sure: the code deals with backward compatibility. > If you're aware of the issue, but don't care (anymore) about it, > then the change is fine (as I can't quite remember the case in > point, and I don't care enough to speculatively page in the > details). g_part_dumpconf() function does set both pair of parameters: (start, end) and (offset, length). I do not see a way how one pair can not be present in XML tree. > If you weren't aware, we should probably determine the impact > before you MFC this. Let me know and I'll dig up the details. -- WBR, Andrey V. Elsukov [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iQEcBAEBAgAGBQJNz/DaAAoJEAHF6gQQyKF6igwH/jXqzeCobQscxOdGDts/e90e iVUO6AL48VplHgY5EHbMWyD/sqhx80Bk/AXoESJVj+WysEpMLZ0chcVHhFAyXW+d /l7WD9jamO+zgV0R7xSiIGZ+500TxiSJ26dohPDqoGhjoqwETEEHQzZIGMQ/ik0z h5lxsbg/oeWNl0YhlcuxIROK/2mR6wLs6LyXk/CJ6QQ6o+LzVvRR5oQpIj/fi7u0 9+n3XakHTHr5GZKwovbSL0oHi7OAQNhvNW+m9wRrZWbpGflZyOYR2kOvTs9a77fV vXrquldmvW10ZA+OWzr/zvgwjeatTofiH/NA3ulBoTd4+GHexF/tEn2sZ9hXVck= =XWfM -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4DCFF0D5.3080309>