Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 03 Sep 2019 14:06:19 -0000
From:      Enji Cooper <yaneurabeya@gmail.com>
To:        Mateusz Guzik <mjg@FreeBSD.org>
Cc:        src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head@freebsd.org
Subject:   Re: svn commit: r345853 - head/usr.bin/rctl
Message-ID:  <EE367002-EC49-41F3-94A8-79F475CC63B8@gmail.com>
In-Reply-To: <201904032037.x33KbEjq070604@repo.freebsd.org>
References:  <201904032037.x33KbEjq070604@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

> On Apr 3, 2019, at 1:37 PM, Mateusz Guzik <mjg@FreeBSD.org> wrote:
>=20
> Author: mjg
> Date: Wed Apr  3 20:37:14 2019
> New Revision: 345853
> URL: https://svnweb.freebsd.org/changeset/base/345853
>=20
> Log:
>  rctl: fix sysctl kern.racct.enable use after r341182
>=20
>  The value was changed from int to bool. Since the new type
>  is smaller, the rest of the variable in the caller was left
>  unitialized.

I hit a bug like this recently with capsicum-test. Do you think it makes =
sense to purge all of the memory or return -1/set EINVAL for reasons =
similar to this for newp?

     [EINVAL]           A non-null newp is given and its specified =
length in
                        newlen is too large or too small.

Thanks!
-Enji=





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?EE367002-EC49-41F3-94A8-79F475CC63B8>