Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 15 Feb 2025 15:51:19 GMT
From:      "Bjoern A. Zeeb" <bz@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: d688c20395a9 - main - net80211: crypto: enhance comment about IEEE80211_RX_F_MMIC_STRIP
Message-ID:  <202502151551.51FFpJOa050390@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by bz:

URL: https://cgit.FreeBSD.org/src/commit/?id=d688c20395a9f46d89edab4c57b863b6d752b061

commit d688c20395a9f46d89edab4c57b863b6d752b061
Author:     Bjoern A. Zeeb <bz@FreeBSD.org>
AuthorDate: 2025-02-15 12:40:40 +0000
Commit:     Bjoern A. Zeeb <bz@FreeBSD.org>
CommitDate: 2025-02-15 15:49:53 +0000

    net80211: crypto: enhance comment about IEEE80211_RX_F_MMIC_STRIP
    
    net80211 crypto currently re-uses the M[ichael]MIC flag for MIC as well
    at least in CCMP.  This is a bit confusing so at least try to improve
    the comment that it becomes more obvious.
    In the long-term we may want to just add a MIC flag as well?
    
    Sponsored by:   The FreeBSD Foundation
    MFC after:      3 days
    Reviewed by:    adrian
    Differential Revision: https://reviews.freebsd.org/D48978
---
 sys/net80211/_ieee80211.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/net80211/_ieee80211.h b/sys/net80211/_ieee80211.h
index 5c7e6110026d..8ae7eb0f1c45 100644
--- a/sys/net80211/_ieee80211.h
+++ b/sys/net80211/_ieee80211.h
@@ -588,7 +588,7 @@ struct ieee80211_mimo_info {
 #define	IEEE80211_RX_F_FAIL_MIC		0x00000080 /* Failed MIC check */
 #define	IEEE80211_RX_F_DECRYPTED	0x00000100 /* Hardware decrypted */
 #define	IEEE80211_RX_F_IV_STRIP		0x00000200 /* Decrypted; IV stripped */
-#define	IEEE80211_RX_F_MMIC_STRIP	0x00000400 /* Decrypted; MMIC stripped */
+#define	IEEE80211_RX_F_MMIC_STRIP	0x00000400 /* Decrypted; [Micheal] MIC ([M]MIC) stripped */
 #define	IEEE80211_RX_F_SHORTGI		0x00000800 /* This is a short-GI frame */
 #define	IEEE80211_RX_F_CCK		0x00001000
 #define	IEEE80211_RX_F_OFDM		0x00002000



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202502151551.51FFpJOa050390>