Date: Sun, 25 Aug 2002 15:32:05 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Giorgos Keramidas <keramida@FreeBSD.ORG> Cc: audit@FreeBSD.ORG Subject: Re: a bin/ls warning with WARNS=5 Message-ID: <20020825152915.K14326-100000@gamplex.bde.org> In-Reply-To: <20020823062636.GA10607@hades.hell.gr>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 23 Aug 2002, Giorgos Keramidas wrote:
> On 2002-08-23 08:47 +0000, Giorgos Keramidas <keramida@FreeBSD.ORG> wrote:
> > WFORMAT=0 remains since I don't know how to fix the format warning :-/
>
> A better fix for the WFORMAT case would probably be:
>
> %%%
> Index: Makefile
> ===================================================================
> RCS file: /home/ncvs/src/bin/ls/Makefile,v
> retrieving revision 1.23
> diff -u -r1.23 Makefile
> --- Makefile 4 Feb 2002 03:06:50 -0000 1.23
> +++ Makefile 23 Aug 2002 06:20:03 -0000
> @@ -3,8 +3,9 @@
>
> PROG= ls
> SRCS= cmp.c lomac.c ls.c print.c util.c
> -NO_WERROR=1
> -WFORMAT=0
> +WARNS?= 5
> +WFORMAT=1
> +CWARNFLAGS= -Wno-format-nonliteral
> DPADD= ${LIBM}
> LDADD= -lm
>
> %%%
No; this adds a hard-coded dependency on gcc. Maybe WFORMAT=0.5 should
give half-baked format checking. The value for half-bakedness would at
least easier to remember than what WARNS=5 means today ;-).
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020825152915.K14326-100000>