Date: Fri, 11 Feb 2005 10:07:32 +0100 From: Anton Berezin <tobez@FreeBSD.org> To: David O'Brien <obrien@FreeBSD.org> Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/Mk bsd.port.mk ports/lang/perl5 Makefile ports/lang/perl5/files use.perl ports/lang/perl5.8 Makefile ports/lang/perl5.8/files use.perl Message-ID: <20050211090732.GA35843@heechee.tobez.org> In-Reply-To: <20050211082953.GA41143@dragon.nuxi.com> References: <200502020934.j129Y5qf027407@repoman.freebsd.org> <20050211082953.GA41143@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
David,
On Fri, Feb 11, 2005 at 12:29:53AM -0800, David O'Brien wrote:
> On Wed, Feb 02, 2005 at 09:34:05AM +0000, Anton Berezin wrote:
> > tobez 2005-02-02 09:34:05 UTC
> ..
> > Log:
> > Update bsd.port.mk's notion of the perl version (to 5.8.6) [1].
> > Use more correct OSVERSION threshold to distinguish between
> > base system perl and perl from ports - the right value is 500036 [1].
> > Also, simplify OSVERSION-related logic in lang/perl5 and lang/perl5.8.
> > Now it goes as follows:
> > - for lang/perl5.8, if there is perl in the base system, install
> > use.perl script, use a helpful pkg-message, and do not automatically
> > update symlinks;
> > - for lang/perl5.8, if there is no perl in the base system, do not
> > install use.perl script, and update symlinks automatically;
>
> I just did 'portupgrade perl-5.8.5' and wound up with
>
> # added by use.perl 2005-02-11 00:18:00
> PERL_VER=5.8.6
> PERL_VERSION=5.8.6
>
> in my /etc/make.conf. Can we please stop spamming /etc/make.conf with
> this? It is a source of very confusing bugs how it overrides
> /usr/ports/Mk/bsd.*.mk for no good reason.
I believe that most of your concerns which you raised back in September
are addressed now, unless I misinterpreted what those concerns were. In
particular, current versions of both lang/perl5 and lang/perl5.8 do not
produce a stream of "added by use.perl" patches to /etc/make.conf, as it
used to be, so the spamming is definitely less severe now. As for the
actual patching of /etc/make.conf, I remember you've mentioned that some
people doing embedded work got confused by this. Let me quote you:
I know some people using FreeBSD in appliances that have been very
puzzled that their perl related changes in ports/Mk/bsd.port.mk
would not take affect -- because they were unknowingly being
overridden by 'use.perl port's /etc/make.conf values.
I don't think this should be a concern. For the majority of people the
change in /etc/make.conf is needed. Those who are modifying bsd.port.mk
should know what they are doing more than most.
\Anton.
--
The moronity of the universe is a monotonically increasing function. --
Jarkko Hietaniemi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050211090732.GA35843>