Date: Fri, 29 Dec 2023 22:46:49 +0100 From: tuexen@fh-muenster.de To: Antoine Brodin <antoine@freebsd.org> Cc: Warner Losh <imp@bsdimp.com>, Dimitry Andric <dim@freebsd.org>, Gleb Smirnoff <glebius@freebsd.org>, Richard Scheffenegger <rscheff@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: a8b70cf26030 - main - netpfil: Use accessor functions and named constants for all tcphdr flags Message-ID: <694F7B7E-145A-46EE-BF32-411FB4FA36F4@fh-muenster.de> In-Reply-To: <CAALwa8mu3HBm8esrzaSWGQzDFkDyfNEhWHjvfLh1ZRz5XfEHHQ@mail.gmail.com> References: <202312270143.3BR1hMQf085312@gitrepo.freebsd.org> <CAALwa8n%2BSs397icBLsYEPZM0ynnou=1Kxc5dV5FAa_CofjpT4A@mail.gmail.com> <ZY34hIExot089sPR@FreeBSD.org> <CAALwa8nf3x6ipG3hBv%2B3j0cHyYq%2BiGUjeMOW1qip%2BNMAXaZL%2Bw@mail.gmail.com> <24134FF7-8C03-490D-A476-4EFF4EAD8132@FreeBSD.org> <0452FE2C-00E9-4E06-880B-6F7B56751728@FreeBSD.org> <CANCZdfqgptdx7OzgbCyozvvPLBeA0MxDwFQUW6R=oSP_QPHunQ@mail.gmail.com> <CAALwa8mu3HBm8esrzaSWGQzDFkDyfNEhWHjvfLh1ZRz5XfEHHQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Dec 29, 2023, at 20:43, Antoine Brodin <antoine@freebsd.org> wrote: > > On Fri, Dec 29, 2023 at 7:33 PM Warner Losh <imp@bsdimp.com> wrote: >> On Fri, Dec 29, 2023, 4:39 AM Dimitry Andric <dim@freebsd.org> wrote: >>> >>> On 29 Dec 2023, at 11:17, Dimitry Andric <dim@FreeBSD.org> wrote: >>>> >>>> On 29 Dec 2023, at 08:35, Antoine Brodin <antoine@FreeBSD.org> wrote: >>>>> >>>>> On Thu, Dec 28, 2023 at 10:37 PM Gleb Smirnoff <glebius@freebsd.org> wrote: >>>>>> >>>>>> Antoine, >>>>>> >>>>>> On Thu, Dec 28, 2023 at 08:48:36PM +0000, Antoine Brodin wrote: >>>>>> A> > netpfil: Use accessor functions and named constants for all tcphdr flags >>>>>> A> > >>>>>> ... >>>>>> A> This breaks some ports: >>>>>> A> /usr/include/netinet/tcp.h:82:8: error: unknown type name 'inline' >>>>>> >>>>>> Definitely some ports that use some strange compilers :) >>>>>> >>>>>> Can you please give at least port names? >>>>> >>>>> Some examples: >>>>> >>>>> https://pkg-status.freebsd.org/gohan04/data/mainamd64PR275986-default-foo/2023-12-28_20h35m41s/logs/errors/nspr-4.35.log >>>>> https://pkg-status.freebsd.org/gohan04/data/mainamd64PR275986-default-foo/2023-12-28_20h35m41s/logs/errors/opusfile-0.12_1.log >>>> >>>> The culprit is likely the "-ansi" option. Just get rid of that, it is not really useful: >>>> >>>> cc -o prmapopt.o -c -fvisibility=hidden -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -ansi -Wall -fPIC -UDEBUG -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DNDEBUG=1 -DHAVE_VISIBILITY_HIDDEN_ATTRIBUTE=1 -DHAVE_VISIBILITY_PRAGMA=1 -DXP_UNIX=1 -DFREEBSD=1 -DHAVE_BSD_FLOCK=1 -DHAVE_SOCKLEN_T=1 -DHAVE_POINTER_LOCALTIME_R=1 -DHAVE_DLADDR=1 -DHAVE_LCHOWN=1 -DHAVE_SETPRIORITY=1 -DHAVE_STRERROR=1 -DHAVE_SYSCALL=1 -DHAVE_SECURE_GETENV=1 -D_REENTRANT=1 -D_THREAD_SAFE=1 -DFORCE_PR_LOG -D_PR_PTHREADS -UHAVE_CVAR_BUILT_ON_SEM -D_NSPR_BUILD_ -I../../../dist/include/nspr -I../../../pr/include -I../../../pr/include/private prmapopt.c >>>> In file included from prmapopt.c:46: >>>> In file included from prmapopt.c:46: >>>> /usr/include/netinet/tcp.h:82:8: error: unknown type name 'inline' >>>> 82 | static inline uint16_t >>>> | ^ >>> >>> Hm, I may have spoken too soon here. If this port has always compiled successfully with -ansi, then indeed it may not be that handy to directly use the 'inline' keyword in system headers. I think most other system headers use '__inline', which is supported by both gcc and clang, even in ANSI mode. And if the compiler somehow does not support __inline, sys/cdefs.h can make sure all those keywords get removed. >> >> >> Yes. You have to use __inline in system headers. > > Yes I confirm that using __inline instead of inline fixes both nspr > and opusfile. Thanks for the feedback. A patch is under discussion: https://reviews.freebsd.org/D43231 Best regards Michael > > Antoine [-- Attachment #2 --] 0 *H 010 `He 0 *H 00 %ف0 *H 01 0 UDE1+0)U "T-Systems Enterprise Services GmbH1 0 U T-Systems Trust Center1%0#U T-TeleSec GlobalRoot Class 20 160222133822Z 310222235959Z01 0 UDE1E0CU <Verein zur Foerderung eines Deutschen Forschungsnetzes e. V.10U DFN-PKI1-0+U$DFN-Verein Certification Authority 20"0 *H 0 `fAsMg9Z`GNWKVlUvFEc>pԫT#7( ]Ę7 fxJ2)y T_Jx4twMYZ/l< 5e 2mZjKb84YE6Ixjm[k<q;gz6N)=Q\ 4 u9 i%=+ ;U*^3 1Fk Y t0p0U 0 U 2&JJK 0 U #0Y 6 y"kaҸ,˂J0U 003U ,0*0 +!,0 +!, 0g 0LU E0C0A?=;http://pki0336.telesec.de/rl/TeleSec_GlobalRoot_Class_2.crl0+z0x0,+0 http://ocsp0336.telesec.de/ocspr0H+0<http://pki0336.telesec.de/crt/TeleSec_GlobalRoot_Class_2.cer0 *H >eV-;qOں)!F.8y8tv]bL3j2,LG`Utk,ykMP f0"rM>[ϙR9. D~i;u ;"lGG4}=wMOY>GJXoB .M<I&6,"͋xU;D RiТSW{$Jer900c ,=0 *H 01 0 UDE1E0CU <Verein zur Foerderung eines Deutschen Forschungsnetzes e. V.10U DFN-PKI1-0+U$DFN-Verein Certification Authority 20 160524113840Z 310222235959Z01 0 UDE1E0CU <Verein zur Foerderung eines Deutschen Forschungsnetzes e. V.10U DFN-PKI1%0#U DFN-Verein Global Issuing CA0"0 *H 0 ;y G i9٢0r )_KhLk {-n:W Q6pmc.@уLf= di囤rh9QyӮ/]cqK9zBi@p翞 MGH_e*I- ? T/:W~xJA}S_ȳ*0$? MR6$eǖs$hYv~ x<K7S:8Gmd=<ZEJʀ|LL 00U 00U 0)U "0 0 +!, 0 +!,0 U k:S୲2 ;t0 U #02&JJK 0U 00@><:http://cdp1.pca.dfn.de/global-root-g2-ca/pub/crl/cacrl.crl0@><:http://cdp2.pca.dfn.de/global-root-g2-ca/pub/crl/cacrl.crl0+003+0'http://ocsp.pca.dfn.de/OCSP-Server/OCSP0J+0>http://cdp1.pca.dfn.de/global-root-g2-ca/pub/cacert/cacert.crt0J+0>http://cdp2.pca.dfn.de/global-root-g2-ca/pub/cacert/cacert.crt0 *H xENU j>xh5 ?k8w,>̨͠3$b6LxnPn`OR1CFubnfQB1gPI9 ˟ʆHK+f8 W-L_>\)9l{F 8ܰ?q 3Hc%%<z{Wn8︠/[Kl=w 3Sv&%Ao/|~ `]AaI)ب-uJU4"0)0 &BґA7?0 *H 01 0 UDE1E0CU <Verein zur Foerderung eines Deutschen Forschungsnetzes e. V.10U DFN-PKI1%0#U DFN-Verein Global Issuing CA0 220530132215Z 250529132215Z01 0 UDE1 0U Nordrhein-Westfalen10U Muenster10U FH Muenster1200U )Fachbereich Elektrotechnik und Informatik10 U Tuexen10U* Michael10U Michael Tuexen0"0 *H 0 {R}HI'ϻYĩhx+C 4P"Ty)PRw Vf>1{Bak eĜ~< 6?cym,m d 3 nDzX l}$v#dij1J b鴽/ ;& "n 6 er8vʝ gKVq}c1ｖ<;i8BU ~X,s|tٯߨ{1H\EfvzZ ؆M/t$1"Q$Usמ>ׅ*fߗqVzwz2졈l7]) &f'c >ڒ'veV)뛿=a/zd! $6m~v<;B?<=(ӂzT 9.#{_aJEP= ɽxO5mtZ q9KHAE1Iٵud[ W K!*-w N N0J0>U 7050 +!,0+!, 0+!, 0 U 0 0U 0 U %0++0 U PD:~WEǴ(q0 U #0k:S୲2 ;t0 U 0tuexen@fh-muenster.de0U 00?=;9http://cdp1.pca.dfn.de/dfn-ca-global-g2/pub/crl/cacrl.crl0?=;9http://cdp2.pca.dfn.de/dfn-ca-global-g2/pub/crl/cacrl.crl0+003+0'http://ocsp.pca.dfn.de/OCSP-Server/OCSP0I+0=http://cdp1.pca.dfn.de/dfn-ca-global-g2/pub/cacert/cacert.crt0I+0=http://cdp2.pca.dfn.de/dfn-ca-global-g2/pub/cacert/cacert.crt0 *H ./x ĬNuӌ.- |2 Rz PtR4`]`OɡX, լUDZP}4?U+ς ` v<[ 7*;j .!8Y{ߣGIV8[xᲒ)*MZX1銘~4kr90@Yۜmy~?Q];2+ܩ̹b0IU0YW{; aU k10001 0 UDE1E0CU <Verein zur Foerderung eines Deutschen Forschungsnetzes e. V.10U DFN-PKI1%0#U DFN-Verein Global Issuing CA &BґA7?0 `He 0 *H 1 *H 0 *H 1 231229214649Z0/ *H 1" l muV ej ecjR+0 +71001 0 UDE1E0CU <Verein zur Foerderung eines Deutschen Forschungsnetzes e. V.10U DFN-PKI1%0#U DFN-Verein Global Issuing CA &BґA7?0 *H 101 0 UDE1E0CU <Verein zur Foerderung eines Deutschen Forschungsnetzes e. V.10U DFN-PKI1%0#U DFN-Verein Global Issuing CA &BґA7?0 *H nUNԆrNyj'6Ն; Bڠ juw&i7Q0RP@ӚTw 2Ly*MMpJwD>jwFĀ2X2mn+;{?mrWNjl3aEfǟ䐚ȆySr-̝mh8CnC0ȟ'O U/O %n+ |FlTĐej,(jle=2FKzc{@e)9u Gʂ 3ɡ#Cs @$H NBE!34VW/HL ndB"X8Q_5 hDHèH6QOE8aGz l | ZuTQYr <Za ^hk P&wI?㺾Z~y.=J! bb{"S$ uzGBߖt'Xٕ]'
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?694F7B7E-145A-46EE-BF32-411FB4FA36F4>