Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 10 Nov 2018 10:31:35 +0000 (UTC)
From:      Hans Petter Selasky <hselasky@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r340316 - stable/11/sys/dev/usb/controller
Message-ID:  <201811101031.wAAAVZaw033730@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: hselasky
Date: Sat Nov 10 10:31:35 2018
New Revision: 340316
URL: https://svnweb.freebsd.org/changeset/base/340316

Log:
  MFC r340212:
  Sometimes the complete split packet may be queued too early and the
  transaction translator will return a NAK. Ignore this message and
  retry the complete split instead.
  
  Sponsored by:		Mellanox Technologies

Modified:
  stable/11/sys/dev/usb/controller/dwc_otg.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/dev/usb/controller/dwc_otg.c
==============================================================================
--- stable/11/sys/dev/usb/controller/dwc_otg.c	Sat Nov 10 10:30:01 2018	(r340315)
+++ stable/11/sys/dev/usb/controller/dwc_otg.c	Sat Nov 10 10:31:35 2018	(r340316)
@@ -1434,6 +1434,19 @@ dwc_otg_host_data_rx(struct dwc_otg_softc *sc, struct 
 					goto receive_pkt;
 				}
 			} else if (td->ep_type == UE_ISOCHRONOUS) {
+				if (td->hcsplt != 0) {
+					/*
+					 * Sometimes the complete
+					 * split packet may be queued
+					 * too early and the
+					 * transaction translator will
+					 * return a NAK. Ignore
+					 * this message and retry the
+					 * complete split instead.
+					 */
+					DPRINTF("Retrying complete split\n");
+					goto receive_pkt;
+				}
 				goto complete;
 			}
 			td->did_nak = 1;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201811101031.wAAAVZaw033730>