Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 8 Sep 2012 19:24:03 +0000 (UTC)
From:      Jilles Tjoelker <jilles@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r240247 - head/bin/sh
Message-ID:  <201209081924.q88JO3Vg042159@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jilles
Date: Sat Sep  8 19:24:03 2012
New Revision: 240247
URL: http://svn.freebsd.org/changeset/base/240247

Log:
  sh: Remove XXX comment about removing nextopt().
  
  Using nextopt() avoids depending on the BSD-specific optreset feature in
  getopt() and reduces code size (both source and binary).

Modified:
  head/bin/sh/options.c

Modified: head/bin/sh/options.c
==============================================================================
--- head/bin/sh/options.c	Sat Sep  8 18:35:15 2012	(r240246)
+++ head/bin/sh/options.c	Sat Sep  8 19:24:03 2012	(r240247)
@@ -531,10 +531,6 @@ out:
 }
 
 /*
- * XXX - should get rid of.  have all builtins use getopt(3).  the
- * library getopt must have the BSD extension static variable "optreset"
- * otherwise it can't be used within the shell safely.
- *
  * Standard option processing (a la getopt) for builtin routines.  The
  * only argument that is passed to nextopt is the option string; the
  * other arguments are unnecessary.  It return the character, or '\0' on



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201209081924.q88JO3Vg042159>