Date: Wed, 21 Oct 2015 18:16:16 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: =?UTF-8?Q?Juan_Ram=c3=b3n_Molina_Menor?= <listjm@club.fr>, freebsd-current@freebsd.org Subject: Re: [CFT] Buildworld ccache support Message-ID: <562838E0.1070004@FreeBSD.org> In-Reply-To: <56280E07.50900@FreeBSD.org> References: <56264279.7020504@club.fr> <56279AD2.6080009@FreeBSD.org> <5627F937.4060301@club.fr> <56280E07.50900@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--qrWN7N7HljIsH499I53fsXJFr0VcuhO06
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
On 10/21/2015 3:13 PM, Bryan Drewery wrote:
> On 10/21/2015 1:44 PM, Juan Ram=F3n Molina Menor wrote:
>> +.if ${CC:M/*} =3D=3D ""
>> +# Can use PATH.
>> +PATH:=3D ${CCACHE_WRAPPER_PATH}:${PATH}
>=20
> These lines in particular did have problems that I fixed recently.
>=20
> - It would potentially add /usr/local/libexec/ccache into PATH multiple=
> times in sub-makes (I think, it may have been my own PATH confusing me)=
=2E
> This would still use ccache.
> - It would consider the '-isystem /usr/obj/...' used for LIB32MAKE to
> match on '${CC:M/*}' which is intended to see if the compiler itself
> starts with a /. In this case of building during build32 ccache was not=
> used.
>=20
> I have since added 'env CCACHE=3D1' to CC and an .info ${PATH} near thi=
s
> code to see if it is working and it sure seems to be working in all of
> the build. This does suggest that using the PATH method may not be goo=
d
> as it leads to confusion about whether it is used or not.
>=20
> I have seen ccache stats get really messed up before. They seemed stuc=
k
> to me earlier. I had updated ccache in ports recently and had been
> building Poudriere using my global ccache dir. Outside of the jail I
> still had the older ccache. This may have led to it messing up my cach=
e
> and stats. Once I upgraded ccache in the host and cleaned the cache it=
> seemed to resume incrementing the counters.
>=20
> I've also since removed the CCP handling from the patch as I found that=
> ccache just records a stat and bails out in that case.
>=20
Subtle changes in the environment or make command line could not use the
cache too. Some of my recent changes in the build system may have caused
no cache to be used in the next build.
--=20
Regards,
Bryan Drewery
--qrWN7N7HljIsH499I53fsXJFr0VcuhO06
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBAgAGBQJWKDjgAAoJEDXXcbtuRpfPEyAIALmGMwYnP3TadX4Fi2wO1zD+
pzVtGegZ+raWyBeY5d4KxAfMoMdB1iSzHBbchWTC47AnYzEZrLqmwQANxEA+Hu6Q
DUXhnrNtNwG2QjfOFYELXbeD9n1yKjjnwAQEX1RypDFCZOW8bhWOQUUEDYFH9n9C
HvJdG5/kojcO9vb/weIY5ua+71ArixAJUZwhriu2qYX8/fmatjzT+kAhzy61GK55
yyQSaQOqg7X2CG4IBj+KInwACqLjk2aAEou1rLF7AR6M74/Tha8/vSMPf63C83oO
AFsyOKFEg5GzRy4wDjZY4+Gv+HGFGpc69IMLbMw2U07U57aNeYx1Dlt+mTZk6zs=
=7U8B
-----END PGP SIGNATURE-----
--qrWN7N7HljIsH499I53fsXJFr0VcuhO06--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?562838E0.1070004>