Date: Wed, 10 May 2017 22:47:14 -0700 From: Ravi Pokala <rpokala@mac.com> To: Kristof Provost <kristof@sigsegv.be> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r318160 - in head: sbin/ifconfig sys/net sys/sys Message-ID: <A78FE4BE-2173-48F2-A4DB-A2E6E7111C51@panasas.com> In-Reply-To: <B2375985-9211-482A-A5EC-98F0077E60DF@sigsegv.be> References: <201705102213.v4AMDlE2074710@repo.freebsd.org> <3F09C117-5017-481D-AAB2-7C64FF23B395@sigsegv.be> <B2375985-9211-482A-A5EC-98F0077E60DF@sigsegv.be>
next in thread | previous in thread | raw e-mail | index | archive | help
-----Original Message----- > From: <owner-src-committers@freebsd.org> on behalf of Kristof Provost <kr= istof@sigsegv.be> > Date: 2017-05-10, Wednesday at 22:38 > To: Ravi Pokala <rpokala@FreeBSD.org> > Cc: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-hea= d@freebsd.org> > Subject: Re: svn commit: r318160 - in head: sbin/ifconfig sys/net sys/sys >=20 > On 11 May 2017, at 11:05, Kristof Provost wrote: >> On 11 May 2017, at 3:43, Ravi Pokala wrote: >>> Author: rpokala >>> Date: Wed May 10 22:13:47 2017 >>> New Revision: 318160 >>> URL: https://svnweb.freebsd.org/changeset/base/318160 >>> >>> Log: >>> Persistently store NIC's hardware MAC address, and add a way to=20 >>> retrive it >>> >> >> This seems to cause panics when I create a bridge interface: >> >> #10 0xffffffff80ef9304 in bcopy () at=20 >> /usr/src/sys/amd64/amd64/support.S:139 >> #11 0xffffffff80b57a80 in ether_ifattach (ifp=3D0xfffff80035663000,=20 >> lla=3D0xfffff800090e13f8 "\002k") at /usr/src/sys/net/if_ethersubr.c:919 >> #12 0xffffffff8325dc67 in bridge_clone_create (ifc=3D<value optimized=20 >> out>, unit=3D<value optimized out>, params=3D<value optimized out>) at=20 >> /usr/src/sys/net/if_bridge.c:704 >> ... >> >> ifp->if_hw_addr is NULL here: >> (kgdb) fr 11 >> #11 0xffffffff80b57a80 in ether_ifattach (ifp=3D0xfffff80035663000,=20 >> lla=3D0xfffff800090e13f8 "\002k") at /usr/src/sys/net/if_ethersubr.c:919 >> 919 bcopy(lla, ifp->if_hw_addr, ifp->if_addrlen); >> (kgdb) p ifp->if_hw_addr >> $1 =3D (void *) 0x0 >> >=20 > This may be because I=E2=80=99ve not yet updated world, just the kernel, but=20 > clearly that still shouldn=E2=80=99t cause panics. >=20 > Regards, > Kristof No, this is purely a kernel mistake -- I forgot to add a NULL-check in ethe= r_ifattach(). :-p Fixing now... -Ravi (rpokala@)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A78FE4BE-2173-48F2-A4DB-A2E6E7111C51>