Date: Sat, 23 Aug 2008 11:34:06 +0900 From: Pyun YongHyeon <pyunyh@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Pyun YongHyeon <yongari@freebsd.org> Subject: Re: cvs commit: src/sys/dev/bfe if_bfe.c if_bfereg.h Message-ID: <20080823023406.GC9758@cdnetworks.co.kr> In-Reply-To: <200808221420.28017.jhb@freebsd.org> References: <200808220647.m7M6lAeL097786@repoman.freebsd.org> <200808221420.28017.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 22, 2008 at 02:20:27PM -0400, John Baldwin wrote: > On Friday 22 August 2008 02:46:55 am Pyun YongHyeon wrote: > > yongari 2008-08-22 06:46:55 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/bfe if_bfe.c if_bfereg.h > > Log: > > SVN rev 181994 on 2008-08-22 06:46:55Z by yongari > > > > Add a new sysctl node 'dev.bfe.N.stats' that shows various MAC > > counters for Rx/Tx statistics. Various counters in ifnet is also > > updated with these hardware counters. > > > > Tested by: kib, Gleb Kurtsou gleb.kurtsou at gmail dot com > > Ulrich Spoerlein uspoerlein at gmail dot com > > I think it's kind of wrong to have sysctl's that print stats in dmesg. You > can either have a sysctl that returns a string and uses sbuf's (e.g. > vm.phys_free) if you want formatting or even better, you can give each stat > it's own sysctl. This is more friendly for people to use when they aren't on > the console (e.g. when you ssh into a box). > I fully agree. Spewing lots of message in dmesg would be wong, especially on slow serial link. I thought these counters would be just used to analyze driver bug or odd driver behavior. It was just for debugging. For long time I wanted a architectural way to add these kind of counters in ethernet drivers. Adding a sysctl node for each counter looked like overkilling at that time and we still don't have a generic tool to dump the stats. I'll think about it again. -- Regards, Pyun YongHyeon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080823023406.GC9758>