Date: Fri, 4 Apr 2003 11:01:08 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: "David O'Brien" <obrien@FreeBSD.org> Cc: Marcel Moolenaar <marcel@xcllnt.net> Subject: Re: cvs commit: src/libexec/talkd announce.c extern.h print.c table.c talkd.c Message-ID: <20030404080108.GB95125@sunbay.com> In-Reply-To: <20030403160301.GE17860@dragon.nuxi.com> References: <200304030513.h335DR60079544@repoman.freebsd.org> <20030402231638.A81523@FreeBSD.org> <20030403055049.GA67232@dhcp01.pn.xcllnt.net> <20030403180026.A29934@gamplex.bde.org> <20030403085350.GA37174@sunbay.com> <20030403093800.GA68012@dhcp01.pn.xcllnt.net> <20030403200459.H30311@gamplex.bde.org> <20030403151922.GA76895@sunbay.com> <20030403160301.GE17860@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Thu, Apr 03, 2003 at 08:03:01AM -0800, David O'Brien wrote:
> On Thu, Apr 03, 2003 at 06:19:22PM +0300, Ruslan Ermilov wrote:
> > I can fix this:
> >
> > %%%
> > Index: bsd.sys.mk
>
> Would this be better?
>
Hardly so.
> Index: bsd.sys.mk
> ===================================================================
> RCS file: /home/ncvs/src/share/mk/bsd.sys.mk,v
> retrieving revision 1.11
> diff -u -r1.11 bsd.sys.mk
> --- bsd.sys.mk 13 Nov 2002 13:49:29 -0000 1.11
> +++ bsd.sys.mk 3 Apr 2003 16:02:28 -0000
> @@ -24,17 +24,11 @@
> . if ${WARNS} > 3
> CFLAGS += -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align
> . endif
> -. if ${WARNS} > 4
> -CFLAGS += -Wuninitialized
> -. endif
> +# XXX: the warning that was here became problematic.
> +#. if ${WARNS} > 4
This hardly can be classified like a fix. :-)
> # BDECFLAGS
> . if ${WARNS} > 5
> CFLAGS += -ansi -pedantic -Wbad-function-cast -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls
> -. endif
> -. if ${WARNS} > 1 && ${WARNS} < 5
> -# XXX Delete -Wuninitialized by default for now -- the compiler doesn't
> -# XXX always get it right.
> -CFLAGS += -Wno-uninitialized
> . endif
> . endif
>
This would be backwards. -Wuninitialized is impled by -Wall,
and revision 1.5 was about to fix this.
Chees,
--
Ruslan Ermilov Sysadmin and DBA,
ru@sunbay.com Sunbay Software AG,
ru@FreeBSD.org FreeBSD committer,
+380.652.512.251 Simferopol, Ukraine
http://www.FreeBSD.org The Power To Serve
http://www.oracle.com Enabling The Information Age
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)
iD8DBQE+jTvEUkv4P6juNwoRApmKAJ9shQ3na1UTR/qzRI2xoimm+g3s1ACdFnlX
+FR0dcrBkByjC3+m6y8PT8s=
=Tql8
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030404080108.GB95125>