Date: Fri, 19 Jan 2018 09:51:23 -0800 From: John Baldwin <jhb@freebsd.org> To: Conrad Meyer <cem@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328159 - head/sys/modules Message-ID: <2915608.v56yfz43Ej@ralph.baldwin.cx> In-Reply-To: <201801190434.w0J4Y6i7086677@repo.freebsd.org> References: <201801190434.w0J4Y6i7086677@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, January 19, 2018 04:34:06 AM Conrad Meyer wrote: > Author: cem > Date: Fri Jan 19 04:34:06 2018 > New Revision: 328159 > URL: https://svnweb.freebsd.org/changeset/base/328159 > > Log: > Unbreak i386 build > > The logical result of a right shift >= the width of a type is zero, but our > compiler decides this is a warning (and thus, error). Just remove ccp(4) > from i386. You would think that. The shift instructions on x86 effectively ignore the upper bits of the count, so a 33-bit shift on i386 ends up being a 1-bit shift, etc. IIRC. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2915608.v56yfz43Ej>