Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 17 Jun 2022 18:49:47 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 264723] the KERN_LOCKF sysctl returns kl_file_fsid that doesn't match st_dev from stat()
Message-ID:  <bug-264723-227-bU9vvMKCAZ@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-264723-227@https.bugs.freebsd.org/bugzilla/>
References:  <bug-264723-227@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D264723

--- Comment #5 from Damjan Jovanovic <damjan.jov@gmail.com> ---
"fsid" is widely used as the name for dev_t fields in sys/user.h: struct
kinfo_file, struct kinfo_ovmentry, struct kinfo_vmentry, and struct
kinfo_vmobject use it.

I don't think we should rename. We are not changing the meaning of the fiel=
d,
we're changing a meaningless field to meaningful field. Code can only break=
 if
it relies on meaningful values, but currently kl_file_fsid is meaningless,
almost like an uninitialized variable. And it's only in CURRENT, so it can
freely change.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-264723-227-bU9vvMKCAZ>