Date: Mon, 15 Apr 2024 14:21:59 +0200 From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= <fernape@freebsd.org> To: Kyle Evans <kevans@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: bc0c6c9cf3a9 - main - freebsd-update: Add check for kernel modules Message-ID: <CAGwOe2aanA%2B0Cp3V_v4cBrWp7L5uYpf-3tZM=dn-tPpUOV_3KQ@mail.gmail.com> In-Reply-To: <6114cce6-dd6e-478f-97af-1a2813f29332@FreeBSD.org> References: <202404141746.43EHkobl002927@gitrepo.freebsd.org> <6114cce6-dd6e-478f-97af-1a2813f29332@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Mon, Apr 15, 2024 at 5:44 AM Kyle Evans <kevans@freebsd.org> wrote: > On 4/14/24 12:46, Fernando Apesteguía wrote: > > The branch main has been updated by fernape: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=bc0c6c9cf3a9f9a54dbdd92dd8f1f65ff8092d17 > > > > commit bc0c6c9cf3a9f9a54dbdd92dd8f1f65ff8092d17 > > Author: Fernando Apesteguía <fernape@FreeBSD.org> > > AuthorDate: 2023-04-19 16:08:47 +0000 > > Commit: Fernando Apesteguía <fernape@FreeBSD.org> > > CommitDate: 2024-04-14 17:46:23 +0000 > > > > freebsd-update: Add check for kernel modules > > > > People get confused when some software (VirtualBox, etc) does not > work as > > expected (or at all) after a major upgrade. > > > > We have a nice way to deal with this when using sources, namely > including > > PORTS_MODULES in /etc/make.conf, but we lack something similar for > binary > > updates. > > > > This patch retrieves a list of kernel modules installed from > packages and > > advises the user to recompile from ports to avoid problems. > > > > Approved by: zlei@ > > Differential Revision: https://reviews.freebsd.org/D39695 > > --- > > usr.sbin/freebsd-update/freebsd-update.sh | 58 > +++++++++++++++++++++++++++++++ > > 1 file changed, 58 insertions(+) > > > > diff --git a/usr.sbin/freebsd-update/freebsd-update.sh > b/usr.sbin/freebsd-update/freebsd-update.sh > > index 4a6a8d78330b..d1cd46963a6c 100644 > > --- a/usr.sbin/freebsd-update/freebsd-update.sh > > +++ b/usr.sbin/freebsd-update/freebsd-update.sh > > @@ -655,6 +655,63 @@ fetch_setup_verboselevel () { > > esac > > } > > > > +# Check if there are any kernel modules installed from ports. > > +# In that case warn the user that a rebuild from ports (i.e. not from > > +# packages) might need necessary for the modules to work in the new > release. > > +upgrade_check_kmod_ports() { > > + local mod_name > > + local modules > > + local pattern > > + local pkg_name > > + local port_name > > + local report > > + local w > > + > > + if ! command -v pkg >/dev/null; then > > + echo "Skipping kernel modules check. pkg(8) not present." > > + return > > + fi > > + > > + # Most modules are in /boot/modules but we should actually look > > + # in every path configured in module_path > > + search_files="/boot/defaults/loader.conf /boot/loader.conf" > > Woof... this is inherently quite fragile, and it completely ignores how > loader.conf are actually processed. The final module_path will always > get passed to the kernel via kenv(1) and exposed as kern.module_path, > please strongly consider just grabbing it from one of them instea . > Thanks for the feedback. kern.module_path seems like the way to do this indeed. Here is a review: https://reviews.freebsd.org/D44797 Cheers. > > Thanks, > > Kyle Evans > [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Apr 15, 2024 at 5:44 AM Kyle Evans <<a href="mailto:kevans@freebsd.org">kevans@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 4/14/24 12:46, Fernando Apesteguía wrote:<br> > The branch main has been updated by fernape:<br> > <br> > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=bc0c6c9cf3a9f9a54dbdd92dd8f1f65ff8092d17" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=bc0c6c9cf3a9f9a54dbdd92dd8f1f65ff8092d17</a><br>; > <br> > commit bc0c6c9cf3a9f9a54dbdd92dd8f1f65ff8092d17<br> > Author: Fernando Apesteguía <fernape@FreeBSD.org><br> > AuthorDate: 2023-04-19 16:08:47 +0000<br> > Commit: Fernando Apesteguía <fernape@FreeBSD.org><br> > CommitDate: 2024-04-14 17:46:23 +0000<br> > <br> > freebsd-update: Add check for kernel modules<br> > <br> > People get confused when some software (VirtualBox, etc) does not work as<br> > expected (or at all) after a major upgrade.<br> > <br> > We have a nice way to deal with this when using sources, namely including<br> > PORTS_MODULES in /etc/make.conf, but we lack something similar for binary<br> > updates.<br> > <br> > This patch retrieves a list of kernel modules installed from packages and<br> > advises the user to recompile from ports to avoid problems.<br> > <br> > Approved by: zlei@<br> > Differential Revision: <a href="https://reviews.freebsd.org/D39695" rel="noreferrer" target="_blank">https://reviews.freebsd.org/D39695</a><br>; > ---<br> > usr.sbin/freebsd-update/freebsd-update.sh | 58 +++++++++++++++++++++++++++++++<br> > 1 file changed, 58 insertions(+)<br> > <br> > diff --git a/usr.sbin/freebsd-update/freebsd-update.sh b/usr.sbin/freebsd-update/freebsd-update.sh<br> > index 4a6a8d78330b..d1cd46963a6c 100644<br> > --- a/usr.sbin/freebsd-update/freebsd-update.sh<br> > +++ b/usr.sbin/freebsd-update/freebsd-update.sh<br> > @@ -655,6 +655,63 @@ fetch_setup_verboselevel () {<br> > esac<br> > }<br> > <br> > +# Check if there are any kernel modules installed from ports.<br> > +# In that case warn the user that a rebuild from ports (i.e. not from<br> > +# packages) might need necessary for the modules to work in the new release.<br> > +upgrade_check_kmod_ports() {<br> > + local mod_name<br> > + local modules<br> > + local pattern<br> > + local pkg_name<br> > + local port_name<br> > + local report<br> > + local w<br> > +<br> > + if ! command -v pkg >/dev/null; then<br> > + echo "Skipping kernel modules check. pkg(8) not present."<br> > + return<br> > + fi<br> > +<br> > + # Most modules are in /boot/modules but we should actually look<br> > + # in every path configured in module_path<br> > + search_files="/boot/defaults/loader.conf /boot/loader.conf"<br> <br> Woof... this is inherently quite fragile, and it completely ignores how <br> loader.conf are actually processed. The final module_path will always <br> get passed to the kernel via kenv(1) and exposed as kern.module_path, <br> please strongly consider just grabbing it from one of them instea .<br></blockquote><div><br></div><div>Thanks for the feedback. kern.module_path seems like the way to do this indeed.<br></div><div><br></div><div>Here is a review:<br></div><div><a href="https://reviews.freebsd.org/D44797">https://reviews.freebsd.org/D44797</a></div><div> </div><div>Cheers.<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br> Thanks,<br> <br> Kyle Evans<br> </blockquote></div></div>help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGwOe2aanA%2B0Cp3V_v4cBrWp7L5uYpf-3tZM=dn-tPpUOV_3KQ>