Date: Fri, 25 Jan 2019 14:29:16 -0800 (PST) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Edward Napierala <trasz@freebsd.org> Cc: rgrimes@freebsd.org, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343440 - head/bin/sh Message-ID: <201901252229.x0PMTGum090514@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <CAFLM3-oSafSxcWSJPEXQ8szLEq5N593fr=sEsup6A2%2BP_VXrgQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> pt., 25 sty 2019 o 19:57 Rodney W. Grimes > <freebsd@pdx.rh.cn85.dnsmgr.net> napisa?(a): > > > > > Author: trasz > > > Date: Fri Jan 25 17:09:26 2019 > > > New Revision: 343440 > > > URL: https://svnweb.freebsd.org/changeset/base/343440 > > > > > > Log: > > > Comment out the default sh(1) aliases for root, introduced in r343416. > > > The rest of this stuff is still to be discussed, but I think at this > > > point we have the agreement that the aliases should go. > > > > > > MFC after: 2 weeks > > > Sponsored by: DARPA, AFRL > > > > Please just revert this and the prior commit out, and when > > the path forward is clear commit it. I would not want any of this > > merged to 12/ or 11/ until the time that it is all settled. > > Oops, my bad - neither this nor the previous commit is supposed > to be MFC-ed; the "2 weeks" above comes from my default Subversion > config. > > Regarding the backoff - just a few hours ago you said you don't have > any problem with this, except for aliases and the default ENV. The > aliases problem has been addressed, and you hadn't yet responded > to my explanations regarding the ENV. Another committer asked for > backoff, because "sh is not an interactive shell", while in fact sh(1) > is FreeBSD's default interactive shell except for root. Finally, there's > one person who asked for revert, but without giving any reasons > whatsoever. > > So far nobody had proposed any scenario where this would break > anything, or even affect existing users. It seems like a typical bikeshed > situation. Within hours of your initial commit you had myself, ian and cy all in opposition to this change , devin asked for a revert, first privately to me which I encouraged a public posting of. Thats four people who want this removed. I have now asked publically for a revert. Thats 2 public request for revert. The hat was only about the MFC statement which you have retracted. Just back it out and we can come to a better solution. Especially dependent on the outcome of Bapts mksh proposal. -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201901252229.x0PMTGum090514>