Date: Sat, 19 Dec 2009 20:01:52 +0100 From: Ed Schouten <ed@80386.nl> To: Kostik Belousov <kostikbel@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r200732 - in head/sys: fs/devfs kern sys Message-ID: <20091219190152.GJ64905@hoeg.nl> In-Reply-To: <20091219185457.GH2170@deviant.kiev.zoral.com.ua> References: <200912191842.nBJIgDgP040506@svn.freebsd.org> <20091219185457.GH2170@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--fZfO+AAAmBD6aS/A Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable * Kostik Belousov <kostikbel@gmail.com> wrote: > Note that struct devfs_dirent is available as vp->v_data, and > devfs_dirent' de_cdp member contains pointer to cdev_priv. I think this > would allow to remove s_ttydp. Well, there are lots of fields that could be derived. We could even remove s_ttyp and only use the vnode, because cdp_c.si_drv1 contains a pointer to the TTY. The reason why I didn't choose that approach, was because I'm a bit afraid we get these insanely long chains of pointer dereferences, of which I'm not entirely sure we do the locking properly. Even right now I'm not sure whether we pick up proctree_lock enough. s_ttydp isn't too strict about any form of locking, because its value is only used comparatively. --=20 Ed Schouten <ed@80386.nl> WWW: http://80386.nl/ --fZfO+AAAmBD6aS/A Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkstIyAACgkQ52SDGA2eCwW+2QCdFgQyWZZU9OZ0bF3NMst6saQ/ vHIAnA/8vvu5SVGTyg6ndImpHoCTDq4t =3nhx -----END PGP SIGNATURE----- --fZfO+AAAmBD6aS/A--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20091219190152.GJ64905>